2022-05-25 01:49:39

by Long Li

[permalink] [raw]
Subject: RE: [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter

> Subject: Re: [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft
> Azure Network Adapter
>
> On Tue, May 24, 2022 at 01:56:12AM -0700, [email protected] wrote:
> > +struct mana_ib_qp {
> > + struct ib_qp ibqp;
> > +
> > + // Send queue info
> > + struct ib_umem *sq_umem;
> > + int sqe;
> > + u64 sq_gdma_region;
> > + u64 sq_id;
>
> There are still lots of coding style violations. Can you get someone from
> Microsoft to help you make patches in the expected form?

I'm sorry, I will fix all the style issues. clang-format and checkpatch.pl didn't catch those.

Long

>
> Also, please don't repost until the next rc1.
>
> Thanks,
> Jason