2020-09-21 20:53:09

by Krzysztof Kozlowski

Subject: [PATCH 08/42] mfd: da9055: use PLATFORM_DEVID_NONE

Use PLATFORM_DEVID_NONE define instead of "-1" value because:
- it brings some meaning,
- it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/mfd/da9055-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
index 6d0af8486269..ff8fe165b937 100644
--- a/drivers/mfd/da9055-core.c
+++ b/drivers/mfd/da9055-core.c
@@ -400,7 +400,7 @@ int da9055_device_init(struct da9055 *da9055)

da9055->irq_base = regmap_irq_chip_get_base(da9055->irq_data);

- ret = mfd_add_devices(da9055->dev, -1,
+ ret = mfd_add_devices(da9055->dev, PLATFORM_DEVID_NONE,
da9055_devs, ARRAY_SIZE(da9055_devs),
NULL, da9055->irq_base, NULL);
if (ret)
--
2.17.1

2020-09-22 09:06:11

by Adam Thomson

Subject: RE: [PATCH 08/42] mfd: da9055: use PLATFORM_DEVID_NONE

On 21 September 2020 21:50, Krzysztof Kozlowski wrote:

> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Adam Thomson <[email protected]>