Subject: [PATCH] video: fbdev: s3c-fb: add COMPILE_TEST support

Add COMPILE_TEST support to s3c-fb driver for better compile
testing coverage.

Cc: Jingoo Han <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
---
drivers/video/fbdev/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Index: b/drivers/video/fbdev/Kconfig
===================================================================
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1877,7 +1877,8 @@ config FB_TMIO_ACCELL

config FB_S3C
tristate "Samsung S3C framebuffer support"
- depends on FB && (CPU_S3C2416 || ARCH_S3C64XX)
+ depends on FB && HAVE_CLK && HAS_IOMEM
+ depends on (CPU_S3C2416 || ARCH_S3C64XX) || COMPILE_TEST
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT


2019-06-18 07:17:56

by Jingoo Han

[permalink] [raw]
Subject: Re: [PATCH] video: fbdev: s3c-fb: add COMPILE_TEST support

On 6/14/19, 11:46 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Add COMPILE_TEST support to s3c-fb driver for better compile
> testing coverage.
>
> Cc: Jingoo Han <[email protected]>
Acked-by: Jingoo Han <[email protected]>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
> ---
> drivers/video/fbdev/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: b/drivers/video/fbdev/Kconfig
> ===================================================================
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1877,7 +1877,8 @@ config FB_TMIO_ACCELL
>
> config FB_S3C
> tristate "Samsung S3C framebuffer support"
> - depends on FB && (CPU_S3C2416 || ARCH_S3C64XX)
> + depends on FB && HAVE_CLK && HAS_IOMEM
> + depends on (CPU_S3C2416 || ARCH_S3C64XX) || COMPILE_TEST
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT

Subject: Re: [PATCH] video: fbdev: s3c-fb: add COMPILE_TEST support


On 6/18/19 8:12 AM, Jingoo Han wrote:
> On 6/14/19, 11:46 PM, Bartlomiej Zolnierkiewicz wrote:
>>
>> Add COMPILE_TEST support to s3c-fb driver for better compile
>> testing coverage.
>>
>> Cc: Jingoo Han <[email protected]>
> Acked-by: Jingoo Han <[email protected]>
>> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>

Thanks, I queued the patch for v5.3.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics