Subject: [PATCH] video: fbdev: s3c-fb: fix sparse warnings about using incorrect types

Use ->screen_buffer instead of ->screen_base to fix sparse warnings.

[ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
pointer") for details. ]

Reported-by: kbuild test robot <[email protected]>
Cc: Jingoo Han <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
---
drivers/video/fbdev/s3c-fb.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

Index: b/drivers/video/fbdev/s3c-fb.c
===================================================================
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1105,14 +1105,14 @@ static int s3c_fb_alloc_memory(struct s3

dev_dbg(sfb->dev, "want %u bytes for window\n", size);

- fbi->screen_base = dma_alloc_wc(sfb->dev, size, &map_dma, GFP_KERNEL);
- if (!fbi->screen_base)
+ fbi->screen_buffer = dma_alloc_wc(sfb->dev, size, &map_dma, GFP_KERNEL);
+ if (!fbi->screen_buffer)
return -ENOMEM;

dev_dbg(sfb->dev, "mapped %x to %p\n",
- (unsigned int)map_dma, fbi->screen_base);
+ (unsigned int)map_dma, fbi->screen_buffer);

- memset(fbi->screen_base, 0x0, size);
+ memset(fbi->screen_buffer, 0x0, size);
fbi->fix.smem_start = map_dma;

return 0;
@@ -1129,9 +1129,9 @@ static void s3c_fb_free_memory(struct s3
{
struct fb_info *fbi = win->fbinfo;

- if (fbi->screen_base)
+ if (fbi->screen_buffer)
dma_free_wc(sfb->dev, PAGE_ALIGN(fbi->fix.smem_len),
- fbi->screen_base, fbi->fix.smem_start);
+ fbi->screen_buffer, fbi->fix.smem_start);
}

/**


2019-06-28 05:50:46

by Jingoo Han

[permalink] [raw]
Subject: Re: [PATCH] video: fbdev: s3c-fb: fix sparse warnings about using incorrect types

On 6/27/19, 9:58 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Use ->screen_buffer instead of ->screen_base to fix sparse warnings.
>
> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
> pointer") for details. ]
>
> Reported-by: kbuild test robot <[email protected]>
> Cc: Jingoo Han <[email protected]>

Acked-by: Jingoo Han <[email protected]>

Best regards,
Jingoo Han

> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
> ---
> drivers/video/fbdev/s3c-fb.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Index: b/drivers/video/fbdev/s3c-fb.c
> ===================================================================
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1105,14 +1105,14 @@ static int s3c_fb_alloc_memory(struct s3
>
> dev_dbg(sfb->dev, "want %u bytes for window\n", size);
>
> - fbi->screen_base = dma_alloc_wc(sfb->dev, size, &map_dma, GFP_KERNEL);
> - if (!fbi->screen_base)
> + fbi->screen_buffer = dma_alloc_wc(sfb->dev, size, &map_dma, GFP_KERNEL);
> + if (!fbi->screen_buffer)
> return -ENOMEM;
>
> dev_dbg(sfb->dev, "mapped %x to %p\n",
> - (unsigned int)map_dma, fbi->screen_base);
> + (unsigned int)map_dma, fbi->screen_buffer);
>
> - memset(fbi->screen_base, 0x0, size);
> + memset(fbi->screen_buffer, 0x0, size);
> fbi->fix.smem_start = map_dma;
>
> return 0;
> @@ -1129,9 +1129,9 @@ static void s3c_fb_free_memory(struct s3
> {
> struct fb_info *fbi = win->fbinfo;
>
> - if (fbi->screen_base)
> + if (fbi->screen_buffer)
> dma_free_wc(sfb->dev, PAGE_ALIGN(fbi->fix.smem_len),
> - fbi->screen_base, fbi->fix.smem_start);
> + fbi->screen_buffer, fbi->fix.smem_start);
> }
>
> /**

Subject: Re: [PATCH] video: fbdev: s3c-fb: fix sparse warnings about using incorrect types


On 6/28/19 7:50 AM, Jingoo Han wrote:
> On 6/27/19, 9:58 PM, Bartlomiej Zolnierkiewicz wrote:
>>
>> Use ->screen_buffer instead of ->screen_base to fix sparse warnings.
>>
>> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
>> pointer") for details. ]
>>
>> Reported-by: kbuild test robot <[email protected]>
>> Cc: Jingoo Han <[email protected]>
>
> Acked-by: Jingoo Han <[email protected]>

Thanks, I queued the patch for v5.3.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics