2002-06-25 16:43:33

by Rusty Russell

[permalink] [raw]
Subject: Re: Typo in arch/mips/dec/wbflush.c

In message <20020624215505.GA7864@galileo> you write:
> --- linux.orig-2.4.19-rc1/arch/mips/dec/wbflush.c Fri Oct 5 13:06:51 200
1
> +++ linux/arch/mips/dec/wbflush.c Mon Jun 24 15:49:53 2002
> @@ -97,7 +97,7 @@
> }
>
> /*
> - * The DS500/2x0 doesnt need to write back the WB.
> + * The DS500/2x0 doesn't need to write back the WB.
> */
> static void wbflush_kn03(void)
> {

Hmm...

I've only applied the one that was an actually a definite
spellfix. While I prefer to use apostrophes, it's a common
abbreviation to skip it: 1/10 according to google. Compare with
another common misspelling (recieve) which is 1/50.

Given there is a non-zero cost (patch conflict with developers) even
with trivial patches, I've decided not to apply your 41
"doesnt"->"doesn't" patches, unless someone convinces me otherwise.

Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.


2002-06-25 17:24:01

by Maciej W. Rozycki

[permalink] [raw]
Subject: Re: Typo in arch/mips/dec/wbflush.c

On Wed, 26 Jun 2002, Rusty Russell wrote:

> In message <20020624215505.GA7864@galileo> you write:
> > --- linux.orig-2.4.19-rc1/arch/mips/dec/wbflush.c Fri Oct 5 13:06:51 200
> 1
> > +++ linux/arch/mips/dec/wbflush.c Mon Jun 24 15:49:53 2002
> > @@ -97,7 +97,7 @@
> > }
> >
> > /*
> > - * The DS500/2x0 doesnt need to write back the WB.
> > + * The DS500/2x0 doesn't need to write back the WB.
> > */
> > static void wbflush_kn03(void)
> > {
>
> Hmm...
>
> I've only applied the one that was an actually a definite
> spellfix. While I prefer to use apostrophes, it's a common
> abbreviation to skip it: 1/10 according to google. Compare with
> another common misspelling (recieve) which is 1/50.
>
> Given there is a non-zero cost (patch conflict with developers) even
> with trivial patches, I've decided not to apply your 41
> "doesnt"->"doesn't" patches, unless someone convinces me otherwise.

There is a formal error in the sentence as well, actually, but I wouldn't
care as the file is to be majorly rewritten (changes are ready and
awaiting an approval of related stuff) and the comment will be removed
anyway.

--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: [email protected], PGP key available +