2002-02-08 16:45:48

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] Tridentfb and resource management

Hi Jani and Marcelo,

Since Tridentfb uses resource management, its initialization must be done
before the initialization of the generic drivers (vesafb and offb).

--- linux-2.4.18-pre9/drivers/video/fbmem.c.orig Fri Feb 8 09:39:18 2002
+++ linux-2.4.18-pre9/drivers/video/fbmem.c Fri Feb 8 17:40:30 2002
@@ -207,6 +207,9 @@
#ifdef CONFIG_FB_SIS
{ "sisfb", sisfb_init, sisfb_setup },
#endif
+#ifdef CONFIG_FB_TRIDENT
+ { "trident", tridentfb_init, tridentfb_setup },
+#endif

/*
* Generic drivers that are used as fallbacks
@@ -229,9 +232,6 @@

#ifdef CONFIG_FB_3DFX
{ "tdfx", tdfxfb_init, tdfxfb_setup },
-#endif
-#ifdef CONFIG_FB_TRIDENT
- { "trident", tridentfb_init, tridentfb_setup },
#endif
#ifdef CONFIG_FB_SGIVW
{ "sgivw", sgivwfb_init, sgivwfb_setup },

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2002-02-08 17:27:44

by James Simmons

[permalink] [raw]
Subject: Re: [Linux-fbdev-devel] [PATCH] Tridentfb and resource management


> Since Tridentfb uses resource management, its initialization must be done
> before the initialization of the generic drivers (vesafb and offb).

I assume you mean the pci_resource_xxx stuff. We really need to move all
the drivers to this.


2002-02-08 19:09:04

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [Linux-fbdev-devel] [PATCH] Tridentfb and resource management

On Fri, 8 Feb 2002, James Simmons wrote:
> > Since Tridentfb uses resource management, its initialization must be done
> > before the initialization of the generic drivers (vesafb and offb).
>
> I assume you mean the pci_resource_xxx stuff. We really need to move all

I meant request_{,mem_}region() (or request_resource()).

> the drivers to this.

Indeed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds