2001-10-29 09:00:12

by Manik Raina

Subject: [Patch] small fix for warning in exec_domain.c

Hi all,

When support for Kernel modules is not configured, we get
a warning. This fix solves that.

thanks
Manik Raina

Index: exec_domain.c
===================================================================
RCS file: /vger/linux/kernel/exec_domain.c,v
retrieving revision 1.21
diff -u -r1.21 exec_domain.c
--- exec_domain.c 25 Oct 2001 20:23:02 -0000 1.21
+++ exec_domain.c 29 Oct 2001 08:40:02 -0000
@@ -77,7 +77,6 @@
lookup_exec_domain(u_long personality)
{
struct exec_domain * ep;
- char buffer[30];
u_long pers = personality(personality);

read_lock(&exec_domains_lock);
@@ -89,8 +88,11 @@

#ifdef CONFIG_KMOD
read_unlock(&exec_domains_lock);
- sprintf(buffer, "personality-%ld", pers);
- request_module(buffer);
+ {
+ char buffer[30];
+ sprintf(buffer, "personality-%ld", pers);
+ request_module(buffer);
+ }
read_lock(&exec_domains_lock);

for (ep = exec_domains; ep; ep = ep->next) {

2001-10-29 13:20:00

by Christoph Hellwig

Subject: Re: [Patch] small fix for warning in exec_domain.c

In article <[email protected]> you wrote:
> Hi all,

> When support for Kernel modules is not configured, we get
> a warning. This fix solves that.

Looks sane to me.

Christoph

--
Of course it doesn't work. We've performed a software upgrade.