2004-03-04 09:44:56

by Meelis Roos

Subject: parport compile error in 2.6.4-r2c (sparc64)

FYI:

drivers/parport/parport_sunbpp.c: In function `init_one_port':
drivers/parport/parport_sunbpp.c:338: warning: passing arg 2 of `request_irq' from incompatible pointer type
drivers/parport/parport_sunbpp.c: In function `parport_sunbpp_exit':
drivers/parport/parport_sunbpp.c:387: error: incompatible type for argument 1 of `list_empty'

--
Meelis Roos ([email protected])

2004-03-04 11:52:00

by Andrew Morton

Subject: Re: parport compile error in 2.6.4-r2c (sparc64)

Meelis Roos <[email protected]> wrote:
>
> drivers/parport/parport_sunbpp.c: In function `init_one_port':
> drivers/parport/parport_sunbpp.c:338: warning: passing arg 2 of `request_irq' from incompatible pointer type
> drivers/parport/parport_sunbpp.c: In function `parport_sunbpp_exit':
> drivers/parport/parport_sunbpp.c:387: error: incompatible type for argument 1 of `list_empty'

Does this fix?


diff -puN drivers/parport/parport_sunbpp.c~parport_sunbpp-build-fix drivers/parport/parport_sunbpp.c
--- 25/drivers/parport/parport_sunbpp.c~parport_sunbpp-build-fix 2004-03-04 03:49:57.000000000 -0800
+++ 25-akpm/drivers/parport/parport_sunbpp.c 2004-03-04 03:50:48.000000000 -0800
@@ -44,9 +44,11 @@
#define dprintk(x)
#endif

-static void parport_sunbpp_interrupt(int irq, void *dev_id, struct pt_regs *regs)
+static irqreturn_t parport_sunbpp_interrupt(int irq, void *dev_id,
+ struct pt_regs *regs)
{
parport_generic_irq(irq, (struct parport *) dev_id, regs);
+ return IRQ_HANDLED;
}

static void parport_sunbpp_disable_irq(struct parport *p)
@@ -384,7 +386,7 @@ static int __init parport_sunbpp_init(vo

static void __exit parport_sunbpp_exit(void)
{
- while (!list_empty(port_list)) {
+ while (!list_empty(&port_list)) {
Node *node = list_entry(port_list.next, Node, list);
struct parport *p = node->port;
struct parport_operations *ops = p->ops;

_

2004-03-04 13:00:22

by Meelis Roos

Subject: Re: parport compile error in 2.6.4-r2c (sparc64)

> Does this fix?

Yes.

--
Meelis Roos ([email protected]) http://www.cs.ut.ee/~mroos/