2004-03-22 10:02:02

by Geert Uytterhoeven

Subject: [PATCH 070] NCR53C9x unused SCp.have_data_in

NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W.
Rozycki). This affects the following drivers:
- Amiga Oktagon SCSI
- DECstation SCSI

The change for DECstation SCSI sneaked in through a MIPS update.

--- linux-2.4.26-pre5/drivers/scsi/NCR53C9x.c Sat Aug 17 14:10:41 2002
+++ linux-m68k-2.4.26-pre5/drivers/scsi/NCR53C9x.c Wed Jan 22 12:07:13 2003
@@ -917,7 +917,7 @@
if (esp->dma_mmu_get_scsi_one)
esp->dma_mmu_get_scsi_one(esp, sp);
else
- sp->SCp.have_data_in = (int) sp->SCp.ptr =
+ sp->SCp.ptr =
(char *) virt_to_phys(sp->request_buffer);
} else {
sp->SCp.buffer = (struct scatterlist *) sp->buffer;
--- linux-2.4.26-pre5/drivers/scsi/oktagon_esp.c Mon Apr 1 13:02:02 2002
+++ linux-m68k-2.4.26-pre5/drivers/scsi/oktagon_esp.c Wed Jan 22 12:07:17 2003
@@ -548,7 +548,7 @@

void dma_mmu_get_scsi_one(struct NCR_ESP *esp, Scsi_Cmnd *sp)
{
- sp->SCp.have_data_in = (int) sp->SCp.ptr =
+ sp->SCp.ptr =
sp->request_buffer;
}


Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2004-03-23 14:22:37

by Marcelo Tosatti

Subject: Re: [PATCH 070] NCR53C9x unused SCp.have_data_in

On Mon, 22 Mar 2004, Geert Uytterhoeven wrote:

> NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W.
> Rozycki). This affects the following drivers:
> - Amiga Oktagon SCSI
> - DECstation SCSI
>
> The change for DECstation SCSI sneaked in through a MIPS update.
>
> --- linux-2.4.26-pre5/drivers/scsi/NCR53C9x.c Sat Aug 17 14:10:41 2002
> +++ linux-m68k-2.4.26-pre5/drivers/scsi/NCR53C9x.c Wed Jan 22 12:07:13 2003
> @@ -917,7 +917,7 @@
> if (esp->dma_mmu_get_scsi_one)
> esp->dma_mmu_get_scsi_one(esp, sp);
> else
> - sp->SCp.have_data_in = (int) sp->SCp.ptr =
> + sp->SCp.ptr =
> (char *) virt_to_phys(sp->request_buffer);
> } else {
> sp->SCp.buffer = (struct scatterlist *) sp->buffer;
> --- linux-2.4.26-pre5/drivers/scsi/oktagon_esp.c Mon Apr 1 13:02:02 2002
> +++ linux-m68k-2.4.26-pre5/drivers/scsi/oktagon_esp.c Wed Jan 22 12:07:17 2003
> @@ -548,7 +548,7 @@
>
> void dma_mmu_get_scsi_one(struct NCR_ESP *esp, Scsi_Cmnd *sp)
> {
> - sp->SCp.have_data_in = (int) sp->SCp.ptr =
> + sp->SCp.ptr =
> sp->request_buffer;
> }

Can't we live with this?

Is removing it fixing any problem?

Yes, I'm being picky.

2004-03-23 15:36:21

by Geert Uytterhoeven

Subject: Re: [PATCH 070] NCR53C9x unused SCp.have_data_in

On Tue, 23 Mar 2004, Marcelo Tosatti wrote:
> On Mon, 22 Mar 2004, Geert Uytterhoeven wrote:
> > NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W.
> > Rozycki). This affects the following drivers:
> > - Amiga Oktagon SCSI
> > - DECstation SCSI
> >
> > The change for DECstation SCSI sneaked in through a MIPS update.
> >
> > --- linux-2.4.26-pre5/drivers/scsi/NCR53C9x.c Sat Aug 17 14:10:41 2002
> > +++ linux-m68k-2.4.26-pre5/drivers/scsi/NCR53C9x.c Wed Jan 22 12:07:13 2003
> > @@ -917,7 +917,7 @@
> > if (esp->dma_mmu_get_scsi_one)
> > esp->dma_mmu_get_scsi_one(esp, sp);
> > else
> > - sp->SCp.have_data_in = (int) sp->SCp.ptr =
> > + sp->SCp.ptr =
> > (char *) virt_to_phys(sp->request_buffer);
> > } else {
> > sp->SCp.buffer = (struct scatterlist *) sp->buffer;
> > --- linux-2.4.26-pre5/drivers/scsi/oktagon_esp.c Mon Apr 1 13:02:02 2002
> > +++ linux-m68k-2.4.26-pre5/drivers/scsi/oktagon_esp.c Wed Jan 22 12:07:17 2003
> > @@ -548,7 +548,7 @@
> >
> > void dma_mmu_get_scsi_one(struct NCR_ESP *esp, Scsi_Cmnd *sp)
> > {
> > - sp->SCp.have_data_in = (int) sp->SCp.ptr =
> > + sp->SCp.ptr =
> > sp->request_buffer;
> > }
>
> Can't we live with this?

Yes.

> Is removing it fixing any problem?

No, it's just a cleanup.

> Yes, I'm being picky.

In that case, you can drop it.

(BTW, picky for 2.4.26-rc*, or for 2.4 in general?)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2004-03-23 16:37:00

by Marcelo Tosatti

Subject: Re: [PATCH 070] NCR53C9x unused SCp.have_data_in

On Tue, 23 Mar 2004, Geert Uytterhoeven wrote:

> On Tue, 23 Mar 2004, Marcelo Tosatti wrote:
> > On Mon, 22 Mar 2004, Geert Uytterhoeven wrote:
> > > NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W.
> > > Rozycki). This affects the following drivers:
> > > - Amiga Oktagon SCSI
> > > - DECstation SCSI
> > >
> > > The change for DECstation SCSI sneaked in through a MIPS update.
> > >
> > > --- linux-2.4.26-pre5/drivers/scsi/NCR53C9x.c Sat Aug 17 14:10:41 2002
> > > +++ linux-m68k-2.4.26-pre5/drivers/scsi/NCR53C9x.c Wed Jan 22 12:07:13 2003
> > > @@ -917,7 +917,7 @@
> > > if (esp->dma_mmu_get_scsi_one)
> > > esp->dma_mmu_get_scsi_one(esp, sp);
> > > else
> > > - sp->SCp.have_data_in = (int) sp->SCp.ptr =
> > > + sp->SCp.ptr =
> > > (char *) virt_to_phys(sp->request_buffer);
> > > } else {
> > > sp->SCp.buffer = (struct scatterlist *) sp->buffer;
> > > --- linux-2.4.26-pre5/drivers/scsi/oktagon_esp.c Mon Apr 1 13:02:02 2002
> > > +++ linux-m68k-2.4.26-pre5/drivers/scsi/oktagon_esp.c Wed Jan 22 12:07:17 2003
> > > @@ -548,7 +548,7 @@
> > >
> > > void dma_mmu_get_scsi_one(struct NCR_ESP *esp, Scsi_Cmnd *sp)
> > > {
> > > - sp->SCp.have_data_in = (int) sp->SCp.ptr =
> > > + sp->SCp.ptr =
> > > sp->request_buffer;
> > > }
> >
> > Can't we live with this?
>
> Yes.
>
> > Is removing it fixing any problem?
>
> No, it's just a cleanup.
>
> > Yes, I'm being picky.
>
> In that case, you can drop it.
>
> (BTW, picky for 2.4.26-rc*, or for 2.4 in general?)

Picky in general for 2.4. In this case specifically I feel the cleanup
can possibly, "remotely" cause some issues. Better to be off.