2004-10-14 22:14:52

by Blaisorblade

[permalink] [raw]
Subject: [patch 1/1] uml: readd linux Makefile target


Since people are used to doing "make linux ARCH=um" and to use "linux" as the
kernel image, make it be an hard link to vmlinux. This should hurt the less
possible the users (actually nothing) while not slowing down the build.

Acked-by: Jeff Dike <[email protected]>

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[email protected]>
---

linux-2.6.9-current-paolo/arch/um/Makefile | 12 ++++++++++++
1 files changed, 12 insertions(+)

diff -puN arch/um/Makefile~uml-readd-linux-target arch/um/Makefile
--- linux-2.6.9-current/arch/um/Makefile~uml-readd-linux-target 2004-10-14 22:52:47.274383552 +0200
+++ linux-2.6.9-current-paolo/arch/um/Makefile 2004-10-14 22:52:47.276383248 +0200
@@ -62,6 +62,18 @@ ifeq ($(CONFIG_MODE_SKAS), y)
$(SYS_HEADERS) : $(ARCH_DIR)/include/skas_ptregs.h
endif

+all: linux
+
+linux: vmlinux
+ $(RM) $@
+ ln $< $@
+
+define archhelp
+ echo '* linux - Binary kernel image (./linux) - for backward'
+ echo ' compatibility only: now you can simply run'
+ echo ' the vmlinux binary you find in the kernel root.'
+endef
+
prepare: $(ARCH_SYMLINKS) $(SYS_HEADERS) $(GEN_HEADERS) \
$(ARCH_DIR)/kernel/vmlinux.lds.S

_


2004-10-15 08:50:56

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [uml-devel] [patch 1/1] uml: readd linux Makefile target

On Fri, 15 Oct 2004 [email protected] wrote:
> Since people are used to doing "make linux ARCH=um" and to use "linux" as the
> kernel image, make it be an hard link to vmlinux. This should hurt the less
> possible the users (actually nothing) while not slowing down the build.
>
> Acked-by: Jeff Dike <[email protected]>
>
> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[email protected]>
> ---
>
> linux-2.6.9-current-paolo/arch/um/Makefile | 12 ++++++++++++
> 1 files changed, 12 insertions(+)
>
> diff -puN arch/um/Makefile~uml-readd-linux-target arch/um/Makefile
> --- linux-2.6.9-current/arch/um/Makefile~uml-readd-linux-target 2004-10-14 22:52:47.274383552 +0200
> +++ linux-2.6.9-current-paolo/arch/um/Makefile 2004-10-14 22:52:47.276383248 +0200
> @@ -62,6 +62,18 @@ ifeq ($(CONFIG_MODE_SKAS), y)
> $(SYS_HEADERS) : $(ARCH_DIR)/include/skas_ptregs.h
> endif
>
> +all: linux
> +
> +linux: vmlinux
> + $(RM) $@
> + ln $< $@
> +
> +define archhelp
> + echo '* linux - Binary kernel image (./linux) - for backward'
> + echo ' compatibility only: now you can simply run'
> + echo ' the vmlinux binary you find in the kernel root.'
> +endef
> +

What happens if you modify the kernel source and rebuild the kernel?
I guess vmlinux gets deleted and replaced, but linux is still the old kernel,
because there's no .phony rule for linux?

What about using a symbolic link instead? It will always point to the most
recent kernel.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds