2001-02-14 17:40:05

by David Hinds

[permalink] [raw]
Subject: Re: [PATCH] network driver updates

On Thu, Feb 15, 2001 at 12:33:43AM +1100, Andrew Morton wrote:
>
> > * something is wrong in the vortex initialization: I don't have such a
> > card, but the driver didn't return an error message on insmod. I'm not
> > sure if my fix is correct.
>
> That was intentional - dhinds suggested that if the hardware
> isn't present the driver should float about in memory anyway.

Say the driver is linked into the kernel. Hot plug drivers should not
all complain about not finding their hardware.

-- Dave


2001-02-14 17:55:05

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] network driver updates

On Wed, 14 Feb 2001, David Hinds wrote:
> On Thu, Feb 15, 2001 at 12:33:43AM +1100, Andrew Morton wrote:
> >
> > > * something is wrong in the vortex initialization: I don't have such a
> > > card, but the driver didn't return an error message on insmod. I'm not
> > > sure if my fix is correct.
> >
> > That was intentional - dhinds suggested that if the hardware
> > isn't present the driver should float about in memory anyway.
>
> Say the driver is linked into the kernel. Hot plug drivers should not
> all complain about not finding their hardware.

Yes; that is the whole reason why pci_register_driver does not error out
when it finds zero matching devices.

Jeff