2001-07-31 20:20:52

by Marc Zyngier

[permalink] [raw]
Subject: [RFC][PATCH] Exporting ___raw_readw and friends on Alpha

Hi all,

I've been trying to use a NE2000 compatible PCMCIA card on my UDB,
using the pcnet_cs driver.

Two symbols were missing from the export list : ___raw_readw and
___raw_writew.

Once these symbols have been added to alpha_ksyms, everything is OK,
and I can enjoy my Multia with 4 ethernet interfaces :-).

Diging through the list archive, I've found the very same patch being
posted by Jan-Benedict Glaw ([email protected]) more than a year ago,
for framebuffer purposes.

Is there any reason why this patch hasn't been applied ? It should be
noted that arch/sh is exporting these symbols too.

Thanks for any comment.

M.

--- /usr/src/linux/arch/alpha/kernel/alpha_ksyms.c Tue Jul 31 19:32:18 2001
+++ linux/arch/alpha/kernel/alpha_ksyms.c Tue Jul 31 21:32:04 2001
@@ -71,6 +71,14 @@
EXPORT_SYMBOL(_writeb);
EXPORT_SYMBOL(_writew);
EXPORT_SYMBOL(_writel);
+EXPORT_SYMBOL(___raw_readb);
+EXPORT_SYMBOL(___raw_readw);
+EXPORT_SYMBOL(___raw_readl);
+EXPORT_SYMBOL(___raw_readq);
+EXPORT_SYMBOL(___raw_writeb);
+EXPORT_SYMBOL(___raw_writew);
+EXPORT_SYMBOL(___raw_writel);
+EXPORT_SYMBOL(___raw_writeq);
EXPORT_SYMBOL(_memcpy_fromio);
EXPORT_SYMBOL(_memcpy_toio);
EXPORT_SYMBOL(_memset_c_io);

--
Places change, faces change. Life is so very strange.


2001-07-31 20:29:42

by Jeff Garzik

[permalink] [raw]
Subject: Re: [RFC][PATCH] Exporting ___raw_readw and friends on Alpha

On 31 Jul 2001, Marc ZYNGIER wrote:
> Two symbols were missing from the export list : ___raw_readw and
> ___raw_writew.

Ok with me... __raw_foo can be used in drivers that know what they are
doing for better performance.

Jeff