2001-10-10 10:20:04

by Luis Montgomery

Subject: 2.4.11: problem with at1700

I try to compile 2.4.11 and find this error:

gcc -D__KERNEL__ -I/usr/src/linux-2.4.11/include -Wall -Wstrict-prototypes
-Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS
-include /usr/src/linux-2.4.11/include/linux/modversions.h -c -o
at1700.o at1700.c
at1700.c:475: conflicting types for `read_eeprom'
at1700.c:161: previous declaration of `read_eeprom'
make[2]: *** [at1700.o] Error 1

Luis Montgomery

2001-10-10 16:08:00

by Jeff Garzik

Subject: Re: 2.4.11: problem with at1700

On Wed, 10 Oct 2001, Luis Montgomery wrote:

>
> I try to compile 2.4.11 and find this error:
>
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.11/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS
> -include /usr/src/linux-2.4.11/include/linux/modversions.h -c -o
> at1700.o at1700.c
> at1700.c:475: conflicting types for `read_eeprom'
> at1700.c:161: previous declaration of `read_eeprom'
> make[2]: *** [at1700.o] Error 1

I sent an incomplete patch to Linus; just back out the patch for wait
for a fix to appear in 2.4.12-pre1...

Jeff

2001-10-10 16:15:11

by Andrew Morton

Subject: Re: 2.4.11: problem with at1700

Luis Montgomery wrote:
>
> I try to compile 2.4.11 and find this error:
>
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.11/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS
> -include /usr/src/linux-2.4.11/include/linux/modversions.h -c -o
> at1700.o at1700.c
> at1700.c:475: conflicting types for `read_eeprom'
> at1700.c:161: previous declaration of `read_eeprom'
> make[2]: *** [at1700.o] Error 1
>

That's an easy one:

--- linux-2.4.11/drivers/net/at1700.c Tue Oct 9 21:31:38 2001
+++ linux-akpm/drivers/net/at1700.c Wed Oct 10 09:03:41 2001
@@ -158,7 +158,7 @@ struct net_local {
extern int at1700_probe(struct net_device *dev);

static int at1700_probe1(struct net_device *dev, int ioaddr);
-static int read_eeprom(int ioaddr, int location);
+static int read_eeprom(long ioaddr, int location);
static int net_open(struct net_device *dev);
static int net_send_packet(struct sk_buff *skb, struct net_device *dev);
static void net_interrupt(int irq, void *dev_id, struct pt_regs *regs);

Incidentally, do you use at1700 much? Does it work OK?
There's an ancient patch at http://web.gnu.walfield.org/mail-archive/linux-kernel/2000-July/3897.html
which seems fairly significant, but it's rare hardware, and I don't
think there have been any bug reports.


-