Subject: [uPATCH] fix IDE/ServerWorks OSB4 config option (test11)


Hi

In drivers/Config.in CONFIG_BLK_DEV_OSB4 depends on itself...

--
Bartlomiej Zolnierkiewicz
<[email protected]>

--- linux-240t11/drivers/ide/Config.in Wed Nov 15 22:02:11 2000
+++ linux/drivers/ide/Config.in Tue Nov 21 14:52:07 2000
@@ -68,7 +68,7 @@
dep_bool ' OPTi 82C621 chipset enhanced support (EXPERIMENTAL)' CONFIG_BLK_DEV_OPTI621 $CONFIG_EXPERIMENTAL
dep_bool ' PROMISE PDC20246/PDC20262/PDC20267 support' CONFIG_BLK_DEV_PDC202XX $CONFIG_BLK_DEV_IDEDMA_PCI
dep_bool ' Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX
- dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_OSB4
+ dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
dep_bool ' SiS5513 chipset support' CONFIG_BLK_DEV_SIS5513 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
dep_bool ' SLC90E66 chipset support' CONFIG_BLK_DEV_SLC90E66 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
dep_bool ' Tekram TRM290 chipset support (EXPERIMENTAL)' CONFIG_BLK_DEV_TRM290 $CONFIG_BLK_DEV_IDEDMA_PCI



2000-11-21 22:26:52

by Jeff Garzik

[permalink] [raw]
Subject: Re: [uPATCH] fix IDE/ServerWorks OSB4 config option (test11)

Bartlomiej Zolnierkiewicz wrote:
> --- linux-240t11/drivers/ide/Config.in Wed Nov 15 22:02:11 2000
> +++ linux/drivers/ide/Config.in Tue Nov 21 14:52:07 2000
> @@ -68,7 +68,7 @@
> dep_bool ' OPTi 82C621 chipset enhanced support (EXPERIMENTAL)' CONFIG_BLK_DEV_OPTI621 $CONFIG_EXPERIMENTAL
> dep_bool ' PROMISE PDC20246/PDC20262/PDC20267 support' CONFIG_BLK_DEV_PDC202XX $CONFIG_BLK_DEV_IDEDMA_PCI
> dep_bool ' Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX
> - dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_OSB4
> + dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' SiS5513 chipset support' CONFIG_BLK_DEV_SIS5513 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' SLC90E66 chipset support' CONFIG_BLK_DEV_SLC90E66 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86


Just wondering, why do these depend on CONFIG_X86?

I just glanced at osb4.c and it looks pretty well-written and portable
to me... Nothing X86 specific about it. Ditto some of the others
depending on CONFIG_X86. IMHO even if the southbridge is currently only
known to be used on x86's, that doesn't mean that the hardware, or the
driver, will always be limited to the X86 platform.

Jeff


--
Jeff Garzik |
Building 1024 | The chief enemy of creativity is "good" sense
MandrakeSoft | -- Picasso

2000-11-22 01:49:14

by Andre Hedrick

[permalink] [raw]
Subject: Re: [uPATCH] fix IDE/ServerWorks OSB4 config option (test11)


Oh well mistakes in Config are okay and not fatal.

Thanks for the find Bart.

Cheers,

On Tue, 21 Nov 2000, Bartlomiej Zolnierkiewicz wrote:

>
> Hi
>
> In drivers/Config.in CONFIG_BLK_DEV_OSB4 depends on itself...
>
> --
> Bartlomiej Zolnierkiewicz
> <[email protected]>
>
> --- linux-240t11/drivers/ide/Config.in Wed Nov 15 22:02:11 2000
> +++ linux/drivers/ide/Config.in Tue Nov 21 14:52:07 2000
> @@ -68,7 +68,7 @@
> dep_bool ' OPTi 82C621 chipset enhanced support (EXPERIMENTAL)' CONFIG_BLK_DEV_OPTI621 $CONFIG_EXPERIMENTAL
> dep_bool ' PROMISE PDC20246/PDC20262/PDC20267 support' CONFIG_BLK_DEV_PDC202XX $CONFIG_BLK_DEV_IDEDMA_PCI
> dep_bool ' Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX
> - dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_OSB4
> + dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' SiS5513 chipset support' CONFIG_BLK_DEV_SIS5513 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' SLC90E66 chipset support' CONFIG_BLK_DEV_SLC90E66 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' Tekram TRM290 chipset support (EXPERIMENTAL)' CONFIG_BLK_DEV_TRM290 $CONFIG_BLK_DEV_IDEDMA_PCI
>
>

Andre Hedrick
CTO Timpanogas Research Group
EVP Linux Development, TRG
Linux ATA Development