2002-04-17 02:05:11

by Andre Hedrick

[permalink] [raw]
Subject: Re: make xconfig fails in 2.5.8 kernel, trivial change to fix it


Gerard,

I am sorry I can not answer you questions about 2.5, since there is a new
maintainer. I am sure he can resolve your 2.5 issue proper.

Andre Hedrick
The Second Linux X-IDE guy


On Tue, 16 Apr 2002, Gerard Beekmans wrote:

> Hi,
>
> There is a very trivial problem in line 52 of the drivers/ide/Config.in
> file. It reads:
> if [ $CONFIG_BLK_DEV_IDE_TCQ_DEFAULT != "n" ]; then
>
> 'make xconfig' fails on this saying that it is a bad if condition:
>
> cat header.tk >> ./kconfig.tk
> ./tkparse < ../arch/i386/config.in >> kconfig.tk
> drivers/ide/Config.in: 52: bad if condition
>
> It is easily fixed by enclosing $CONFIG_BLK_DEV_IDE_TCQ_DEFAULT in double
> quotes. There are other if conditions in this same file that do have those
> quotes and Tk doesn't complain about them.
>
> Does anybody use xconfig these days anyways since nobody apprarently has
> noticed it before? I saw this broken a few 2.5 releases ago too but never
> got around looking into it.
>
>
>
> --
> Gerard Beekmans
> http://www.linuxfromscratch.org
>
> -*- If Linux doesn't have the solution, you have the wrong problem -*-
>