2000-12-05 12:54:40

by Tigran Aivazian

[permalink] [raw]
Subject: 2.4.0-test12-pre5 breaks vmware (again)

Hi Petr,

In case you haven't noticed yet -- the 'features' field of /proc/cpuinfo
has been changed again so vmware won't run anymore. The fix is just as
obvious as the previous one -- to change /usr/bin/vmware-config.pl script
from grepping for 'features' to grep for 'flags'. I think 'flags' is what
it used to be called ages ago but that is irrelevant -- everyone
presumably already changed all their software to use 'features' (I did,
for example) and forgot about the old 'flags' forever....

Regards,
Tigran


2000-12-05 13:25:31

by Petr Vandrovec

[permalink] [raw]
Subject: Re: 2.4.0-test12-pre5 breaks vmware (again)

On 5 Dec 00 at 12:25, Tigran Aivazian wrote:

> In case you haven't noticed yet -- the 'features' field of /proc/cpuinfo
> has been changed again so vmware won't run anymore. The fix is just as
> obvious as the previous one -- to change /usr/bin/vmware-config.pl script
> from grepping for 'features' to grep for 'flags'. I think 'flags' is what
> it used to be called ages ago but that is irrelevant -- everyone
> presumably already changed all their software to use 'features' (I did,
> for example) and forgot about the old 'flags' forever....

Blessed vmware-config.pl contains

\(flags\|features\).*

so it should run...
Petr

2000-12-05 22:10:56

by Peter Samuelson

[permalink] [raw]
Subject: Re: 2.4.0-test12-pre5 breaks vmware (again)

[Tigran Aivazian]
> I think 'flags' is what it used to be called ages ago but that is
> irrelevant -- everyone presumably already changed all their software
> to use 'features' (I did, for example) and forgot about the old
> 'flags' forever....

Ages ago? s/flags/features/ happened in test11pre5. I doubt most of
the world had switched yet.

Peter

2000-12-05 22:15:46

by Alan

[permalink] [raw]
Subject: Re: 2.4.0-test12-pre5 breaks vmware (again)

> > presumably already changed all their software to use 'features' (I did,
> > for example) and forgot about the old 'flags' forever....
>
> Blessed vmware-config.pl contains
>
> \(flags\|features\).*
>
> so it should run...

vmware-config as used by the other 99.9999% of people does not

2000-12-05 22:16:16

by Tigran Aivazian

[permalink] [raw]
Subject: Re: 2.4.0-test12-pre5 breaks vmware (again)

On Tue, 5 Dec 2000, Peter Samuelson wrote:

> [Tigran Aivazian]
> > I think 'flags' is what it used to be called ages ago but that is
> > irrelevant -- everyone presumably already changed all their software
> > to use 'features' (I did, for example) and forgot about the old
> > 'flags' forever....
>
> Ages ago? s/flags/features/ happened in test11pre5. I doubt most of
> the world had switched yet.

well, if you look very carefully you will see a missing \t so the new
value of that field in the /proc/cpuinfo at the moment is quite unique :)
(but Hugh Dickins, I think, posted a patch today which fixes this)

(yes, I know that the vmware script (especially Petr's latest
version) deals correctly with any combination of features/flags with and
without tabs).

Regards,
Tigran