2001-02-05 20:16:45

by Dunlap, Randy

[permalink] [raw]
Subject: Q. on marking __initdata

Hi,

Just a question (not a patch proposal):

Could
+/* # of MP IRQ source entries */
+struct mpc_config_intsrc mp_irqs[MAX_IRQ_SOURCES];

in arch/i386/kernel/mpparse.c (in 2.4.1-ac3; or in
arch/i386/kernel/io_apic.c in 2.4.1) be marked as
__initdata ? If not, why not? Or is __initdata
not needed on it for some reason (and if so, what
reason)?

Thanks,
~Randy_________________________________________


2001-02-05 20:39:20

by Tigran Aivazian

[permalink] [raw]
Subject: Re: Q. on marking __initdata

and, while you are at it, you should (probably) also mark pin_2_irq() and
IO_APIC_get_PCI_irq_vector() functions as __init as well, for exactly the
same reason as what you noticed.

Regards,
Tigran

On Mon, 5 Feb 2001, Dunlap, Randy wrote:

> Hi,
>
> Just a question (not a patch proposal):
>
> Could
> +/* # of MP IRQ source entries */
> +struct mpc_config_intsrc mp_irqs[MAX_IRQ_SOURCES];
>
> in arch/i386/kernel/mpparse.c (in 2.4.1-ac3; or in
> arch/i386/kernel/io_apic.c in 2.4.1) be marked as
> __initdata ? If not, why not? Or is __initdata
> not needed on it for some reason (and if so, what
> reason)?
>
> Thanks,
> ~Randy_________________________________________
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> Please read the FAQ at http://www.tux.org/lkml/
>