Could someone with Dell laptops test this for me ?
Thanks
---------- Forwarded message ----------
Date: Wed, 26 Dec 2001 20:14:11 +0000
From: Alan Ford <[email protected]>
To: Marcelo Tosatti <[email protected]>
Subject: 2.4.17: Dell Laptop extra buttons patch
Hi Marcelo,
Would you consider adding this patch to the next kernel release? I've been
using it for a while, and since there is now the Dell laptop module for
extra BIOS features available in the kernel it seems this patch could be
appropriate and useful to include. It adds keycodes for the four shortcut
buttons that are provided on Dell Inspiron laptops.
Regards,
Alan
--
Alan Ford * [email protected]
On Wed, 26 Dec 2001, Andreas Dilger wrote:
> On Dec 26, 2001 17:11 -0200, Marcelo Tosatti wrote:
> > Could someone with Dell laptops test this for me ?
>
> I don't have a Dell laptop, but AFAIK in the past patches like this have
> been rejected by Andries Brouwer (I think) because it is possible to do
> this from user space with key mapping tools like setkeycodes, xkeycaps,
> or xmodmap.
Yes, right. Alan just told me the same.
Thanks
On Dec 26, 2001 17:11 -0200, Marcelo Tosatti wrote:
> Could someone with Dell laptops test this for me ?
I don't have a Dell laptop, but AFAIK in the past patches like this have
been rejected by Andries Brouwer (I think) because it is possible to do
this from user space with key mapping tools like setkeycodes, xkeycaps,
or xmodmap.
Cheers, Andreas
> ---------- Forwarded message ----------
> From: Alan Ford <[email protected]>
>
> Would you consider adding this patch to the next kernel release? I've been
> using it for a while, and since there is now the Dell laptop module for
> extra BIOS features available in the kernel it seems this patch could be
> appropriate and useful to include. It adds keycodes for the four shortcut
> buttons that are provided on Dell Inspiron laptops.
>
> Regards,
> Alan
> --
> Alan Ford * [email protected]
> --- linux/drivers/char/pc_keyb.c.old Wed Dec 26 19:06:21 2001
> +++ linux/drivers/char/pc_keyb.c Wed Dec 26 19:08:13 2001
> @@ -228,9 +228,17 @@
> #define E0_MSLW 125
> #define E0_MSRW 126
> #define E0_MSTM 127
> +/*
> + * Dell Inspiron Laptop Keyboard has four shortcut buttons
> + * e0 01 - e0 04 [[email protected]]
> + */
> +#define E0_DELL1 121
> +#define E0_DELL2 122
> +#define E0_DELL3 123
> +#define E0_DELL4 124
>
> static unsigned char e0_keys[128] = {
> - 0, 0, 0, 0, 0, 0, 0, 0, /* 0x00-0x07 */
> + 0, E0_DELL1, E0_DELL2, E0_DELL3, E0_DELL4, 0, 0, 0, /* 0x00-0x07 */
> 0, 0, 0, 0, 0, 0, 0, 0, /* 0x08-0x0f */
> 0, 0, 0, 0, 0, 0, 0, 0, /* 0x10-0x17 */
> 0, 0, 0, 0, E0_KPENTER, E0_RCTRL, 0, 0, /* 0x18-0x1f */
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/
>I don't have a Dell laptop, but AFAIK in the past patches like this have
>been rejected by Andries Brouwer (I think) because it is possible to do
>this from user space with key mapping tools like setkeycodes, xkeycaps,
>or xmodmap.
I can't see a possible reason _not_ to have it in there anyway, the 0
values take up space so bloat is not a valid reason. I can understand that
since its possible in userland we should leave it there, but this is
fairly harmless stuff which doesn't affect anything.
Regards,
Zwane Mwaikambo