2002-01-15 23:09:47

by Marcelo Tosatti

[permalink] [raw]
Subject: Linux 2.4.18-pre4


So here goes pre4.

pre4:

- Networking updates (David S. Miller)
- clgenfb update (Jeff Garzik)
- 8139cp: make it faster (Jeff Garzik)
- 8139too: fix bugs, add experimental RX reset (Jeff Garzik)
- Add MII ethtool interface and change
several drivers to support that (Jeff Garzik)
- Fix ramdisk corruption problems (Andrea Arcangeli)
- Correct in-kernel MS_ASYNC behaviour
on msync/fsync() (Andrew Morton)
- Fix PLIP problems (Niels Jensen)
- Fix problems triggered by the "fsx test"
on smbfs (Urban Widmark)
- Turn on OOSTORE for IDT winchip (from -ac tree)
- Fix iphase crash (from -ac tree)
- Fix crash with two mxser cards (from -ac tree)
- Fix tty write block bug (from -ac tree)
- Add mono/stereo detect to gemtek pci radio (from -ac tree)
- Fix sf16fmi crash on load (from -ac tree)
- add CP1250 (windows eastern european)
translation table (from -ac tree)
- cs46xx driver update (from -ac tree)
- Fix rare data loss case with RAID-1 (Ingo Molnar)
- Add 2.5.x compatibility for the kdev_t
changes (me)
- SPARC updates (David S. Miller)

pre3:

- Cris arch merge (Bjorn Wesen)
- Finish PPC merge (Benjamin Herrenschmidt)
- Add Dell PowerEdge 2400 to
"use BIOS to reboot" blacklist (Arjan van de Ven)
- Avoid potential oops at module unload with
cyclades driver (Andrew Morton)
- Gracefully handle SCSI initialization
failures (Pete Zaitcev)
- USB update (Greg KH)
- Fix potential oops while ejecting ide cds (Zwane Mwaikambo)
- Unify page freeing codepaths (Benjamin LaHaise)
- Miata dma corruption workaround (Richard Henderson)
- Fix vmalloc corruption problem on machines
with virtual dcaches (Ralf Baechle)
- Reiserfs fixes (Oleg Drokin)
- DiskOnChip driver update (David Woodhouse)
- Do not inherit page locking rules across
fork/exec (Dave Anderson)
- Add DRM 4.0 for XFree 4.0 users convenience (Christoph Hellwig)
- Replace .text.lock with .subsection (Keith Owens)
- IrDA bugfixes (Jean Tourrilhes)

pre2:

- APIC LVTERR fixes (Mikael Pettersson)
- Fix ppdev ioctl oops and deadlock (Tim Waugh)
- parport fixes (Tim Waugh)
- orinoco wireless driver update (David Gibson)
- Fix oopsable race in binfmt_elf.c (Alexander Viro)
- Small sx16 driver bugfix (Heinz-Ado Arnolds)
- sbp2 deadlock fix (Andrew Morton)
- Fix JFFS2 write error handling (David Woodhouse)
- Intermezzo update (Peter J. Braam)
- Proper AGP support for Intel 830MP chipsets (Nicolas Aspert)
- Alpha fixes (Jay Estabrook)
- 53c700 SCSI driver update (James Bottomley)
- Fix coredump mmap_sem deadlock on IA64 (David Mosberger)
- 3ware driver update (Adam Radford)
- Fix elevator insertion point on failed
request merge (Jens Axboe)
- Remove bogus rpciod_tcp_dispatcher definition (David Woodhouse)
- Reiserfs fixes (Oleg Drokin)
- de4x5 endianess fixes (Kip Walker)
- ISDN CAPI cleanup (Kai Germaschewski)
- Make refill_inactive() correctly account
progress (me)

pre1:

- S390 merge (IBM)
- SuperH merge (SuperH team)
- PPC merge (Benjamin Herrenschmidt)
- PCI DMA update (David S. Miller)
- radeonfb update (Ani Joshi)
- aty128fb update (Ani Joshi)
- Add nVidia GeForce3 support to rivafb (Ani Joshi)
- Add PM support to opl3sa2 (Zwane Mwaikambo)
- Basic ethtool support for 3com, starfire
and pcmcia net drivers (Jeff Garzik)
- Add MII ethtool interface (Jeff Garzik)
- starfire,sundance,dl2k,sis900,8139{too,cp},
natsemi driver updates (Jeff Garzik)
- ufs/minix: mark inodes as bad in case of read
failure (Christoph Hellwig)
- ReiserFS fixes (Oleg Drokin)
- sonypi update (Stelian Pop)
- n_hdlc update (Paul Fulghum)
- Fix compile error on aty_base.c (Tobias Ringstrom)
- Document cpu_to_xxxx() on kernel-hacking doc (Rusty Russell)
- USB update (Greg KH)
- Fix sysctl console loglevel bug on
IA64 (and possibly other archs) (Jesper Juhl)
- Update Athlon/VIA PCI quirks (Calin A. Culianu)
- blkmtd update (Simon Evans)
- boot protocol update (makes the highest
possible initrd address available to the
bootloader) (H. Peter Anvin)
- NFS fixes (Trond Myklebust)




2002-01-16 00:30:27

by Stephan von Krawczynski

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre4

>
> So here goes pre4.

aehm, did I spoil it myself, or is it someone else:

compiling .... and then:

find kernel -path '*/pcmcia/*' -name '*.o' | xargs -i -r ln -sf ../{}
pcmcia
if [ -r System.map ]; then /sbin/depmod -ae -F System.map
2.4.18-pre4; fi
depmod: *** Unresolved symbols in
/lib/modules/2.4.18-pre4/kernel/fs/minix/minix.o
depmod: waitfor_one_page

..config was taken over from 2.4.17, where it was working.

??

Regards,
Stephan



2002-01-16 00:37:07

by Marcelo Tosatti

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre4



On Wed, 16 Jan 2002, Stephan von Krawczynski wrote:

> >
> > So here goes pre4.
>
> aehm, did I spoil it myself, or is it someone else:
>
> compiling .... and then:
>
> find kernel -path '*/pcmcia/*' -name '*.o' | xargs -i -r ln -sf ../{}
> pcmcia
> if [ -r System.map ]; then /sbin/depmod -ae -F System.map
> 2.4.18-pre4; fi
> depmod: *** Unresolved symbols in
> /lib/modules/2.4.18-pre4/kernel/fs/minix/minix.o
> depmod: waitfor_one_page
>
> ..config was taken over from 2.4.17, where it was working.
>
> ??

My mistake. Add "EXPORT_SYMBOL(waitfor_one_page);" to kernel/ksyms.c.

Already fixed in my tree.

Thanks.


2002-01-16 09:23:18

by Ingo Oeser

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre4

On Tue, Jan 15, 2002 at 07:56:38PM -0200, Marcelo Tosatti wrote:
[pre4 Announcement]

What is this hunk supposed to do?
diff -urN linux-2.4.18-pre3/fs/buffer.c linux/fs/buffer.c
--- linux-2.4.18-pre3/fs/buffer.c Fri Dec 21 09:41:55 2001
+++ linux/fs/buffer.c Tue Jan 15 15:10:18 2002
@@ -1633,12 +1671,34 @@
*/
while(wait_bh > wait) {
wait_on_buffer(*--wait_bh);
- err = -EIO;
if (!buffer_uptodate(*wait_bh))
- goto out;
+ return -EIO;
}
return 0;
out:
+ /*
+ * Zero out any newly allocated blocks to avoid exposing stale
+ * data. If BH_New is set, we know that the block was newly
+ * allocated in the above loop.
+ */
+ bh = head;
+ block_start = 0;
[1]
+ do {
+ block_end = block_start+blocksize;
+ if (block_end <= from)
+ continue;
[2]

The situation between [1] and [2] won't change, so I don't
understand the "continue" here and think it will either never be
triggered or an endless loop.

Could you or the one introducing this clarify?

Thanks & Regards

Ingo Oeser
--
Science is what we can tell a computer. Art is everything else. --- D.E.Knuth
>>> 4. Chemnitzer Linux-Tag - 09.+10. Maerz 2002 <<<
http://www.tu-chemnitz.de/linux/tag/

2002-01-16 09:39:00

by Andrew Morton

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre4

Ingo Oeser wrote:
>
> On Tue, Jan 15, 2002 at 07:56:38PM -0200, Marcelo Tosatti wrote:
> [pre4 Announcement]
>
> What is this hunk supposed to do?
> diff -urN linux-2.4.18-pre3/fs/buffer.c linux/fs/buffer.c
> --- linux-2.4.18-pre3/fs/buffer.c Fri Dec 21 09:41:55 2001
> +++ linux/fs/buffer.c Tue Jan 15 15:10:18 2002
> @@ -1633,12 +1671,34 @@
> */
> while(wait_bh > wait) {
> wait_on_buffer(*--wait_bh);
> - err = -EIO;
> if (!buffer_uptodate(*wait_bh))
> - goto out;
> + return -EIO;
> }
> return 0;
> out:
> + /*
> + * Zero out any newly allocated blocks to avoid exposing stale
> + * data. If BH_New is set, we know that the block was newly
> + * allocated in the above loop.
> + */
> + bh = head;
> + block_start = 0;
> [1]
> + do {
> + block_end = block_start+blocksize;
> + if (block_end <= from)
> + continue;
> [2]
>
> The situation between [1] and [2] won't change, so I don't
> understand the "continue" here and think it will either never be
> triggered or an endless loop.
>

Good eyes. I missed that in both reviewing and in testing.

I'll go test this:

--- linux-2.4.18-pre4/fs/buffer.c Tue Jan 15 15:08:25 2002
+++ linux-akpm/fs/buffer.c Wed Jan 16 01:30:25 2002
@@ -1686,7 +1686,7 @@ out:
do {
block_end = block_start+blocksize;
if (block_end <= from)
- continue;
+ goto next_bh;
if (block_start >= to)
break;
if (buffer_new(bh)) {
@@ -1696,6 +1696,7 @@ out:
set_bit(BH_Uptodate, &bh->b_state);
mark_buffer_dirty(bh);
}
+next_bh:
block_start = block_end;
bh = bh->b_this_page;
} while (bh != head);

2002-01-16 09:45:18

by Alexander Viro

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre4



On Wed, 16 Jan 2002, Ingo Oeser wrote:

> [1]
> + do {
> + block_end = block_start+blocksize;
> + if (block_end <= from)
> + continue;
> [2]
>
> The situation between [1] and [2] won't change, so I don't
> understand the "continue" here and think it will either never be
> triggered or an endless loop.
>
> Could you or the one introducing this clarify?

Lovely... Thanks for spotting.
--- fs/buffer.c Wed Jan 16 04:39:56 2002
+++ fs/buffer.c.new Wed Jan 16 04:43:29 2002
@@ -1686,7 +1686,7 @@
do {
block_end = block_start+blocksize;
if (block_end <= from)
- continue;
+ goto skip_it;
if (block_start >= to)
break;
if (buffer_new(bh)) {
@@ -1696,6 +1696,7 @@
set_bit(BH_Uptodate, &bh->b_state);
mark_buffer_dirty(bh);
}
+ skip_it:
block_start = block_end;
bh = bh->b_this_page;
} while (bh != head);

2002-01-16 10:37:20

by Matthias Andree

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre4

On Tue, 15 Jan 2002, Marcelo Tosatti wrote:

> So here goes pre4.
>
> pre4:
>
> - Networking updates (David S. Miller)

I've seen this line various times, and I know the details are available
elsewhere, but the verbosity of this is inconsistent with the rest of
your entries. "Networking updates" can be bugfix, compatibility fix,
policy change, whatever; may I ask that you include some information to
the nature of these "Networking updates" please or, alternatively, send
an URL to the corresponding "Networking updates" ChangeLog?

Thanks a lot.

Also, do you plan to integrate Andre's IDE patches soon? Is it scheduled
for e. g. 2.4.19-pre1?

Matthias

2002-01-16 10:34:10

by Eyal Lebedinsky

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre4: missing cs4281_wrapper.h

Marcelo Tosatti wrote:
>
> So here goes pre4.

gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i686 -malign-functions=4 -DMODULE -DMODVERSIONS -include
/data2/usr/local/src/linux-2.4-pre/include/linux/modversions.h
-DKBUILD_BASENAME=cs4281m -c -o cs4281m.o cs4281m.c
cs4281m.c:100: cs4281_wrapper.h: No such file or directory
make[3]: *** [cs4281m.o] Error 1
make[3]: Leaving directory
`/data2/usr/local/src/linux-2.4-pre/drivers/sound/cs4281'

--
Eyal Lebedinsky ([email protected]) <http://samba.org/eyal/>