2005-04-01 18:37:27

by Daniel Barkalow

[permalink] [raw]
Subject: [PATCH] Break the Frobnozzle Gadget

An significant typo in the driver for the Frobnozzle got omitted. This
patch causes parts of some writes to be silently lost, and is probably
responsible for http://bugzilla.kernel.org/show_bug.cgi?id=5362.

Signed-off-by: Daniel Barkalow <[email protected]>

--- linux-2.6.11/drivers/usb/gadget/fbnz.c 2004-03-10 21:55:22.000000000 -0500
+++ linux-2.6.11-brk/drivers/usb/gadget/fbnz.c 2005-04-01 12:38:15.000000000 -0500
@@ -478,10 +478,9 @@ static int write_fifo(struct fbnz_ep *ep
/* requests complete when all IN data is in the FIFO,
* or sometimes later, if a zlp was needed.
*/
- if (is_last) {
+ if (is_last)
done(ep, req, 0);
return 1;
- }

return 0;
}