2002-02-04 07:05:29

by Calin A. Culianu

[permalink] [raw]
Subject: [PATCH] 2.4.18-pre7 Fixed typo that made compiling impossible in /net/ipv4/netfilter/ipfwadm_core.c


/net/ipv4/netfilter/ipfwadm_core.c has a typo. The MOD_*_USE_COUNT macros
are being used incorrectly. Compiling was impossible as a result.

I fixed the typos. It's trivial, but I figured I'd submit this just to
make it easier for marcello to fix this...? (this may have been submitted
by someone else already.. but my quick scan of the mailing list didn't
reveal anyone having patched this).

-Calin


Attachments:
2.4.18-pre7_ipfwadm_core_typo_fix.patch (809.00 B)

2002-02-04 07:42:39

by Harald Welte

[permalink] [raw]
Subject: Re: [PATCH] 2.4.18-pre7 Fixed typo that made compiling impossible in /net/ipv4/netfilter/ipfwadm_core.c

On Mon, Feb 04, 2002 at 02:04:58AM -0500, Calin A. Culianu wrote:
>
> /net/ipv4/netfilter/ipfwadm_core.c has a typo. The MOD_*_USE_COUNT macros
> are being used incorrectly. Compiling was impossible as a result.
>
> I fixed the typos. It's trivial, but I figured I'd submit this just to
> make it easier for marcello to fix this...? (this may have been submitted
> by someone else already.. but my quick scan of the mailing list didn't
> reveal anyone having patched this).

It has already been submitted, but thanks anyway :)

> -Calin

--
Live long and prosper
- Harald Welte / [email protected] http://www.gnumonks.org/
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M-
V-- PS+ PE-- Y+ PGP++ t++ 5-- !X !R tv-- b+++ DI? !D G+ e* h+ r% y+(*)

2002-02-04 15:04:47

by Calin A. Culianu

[permalink] [raw]
Subject: Re: [PATCH] 2.4.18-pre7 Fixed typo that made compiling impossible in /net/ipv4/netfilter/ipfwadm_core.c



On Mon, 4 Feb 2002, Harald Welte wrote:

> On Mon, Feb 04, 2002 at 02:04:58AM -0500, Calin A. Culianu wrote:
> >
> > /net/ipv4/netfilter/ipfwadm_core.c has a typo. The MOD_*_USE_COUNT macros
> > are being used incorrectly. Compiling was impossible as a result.
> >
> > I fixed the typos. It's trivial, but I figured I'd submit this just to
> > make it easier for marcello to fix this...? (this may have been submitted
> > by someone else already.. but my quick scan of the mailing list didn't
> > reveal anyone having patched this).
>
> It has already been submitted, but thanks anyway :)


Hehe I figured it would have been.. having both the properties of being
obvious and trivial. :)


>
> > -Calin
>
>