This patch fixes some issues with the frame buffer device penguin logo code.
Bug list:
- The colors for the 16 color logo are wrong. We used a hack to give the logo
its own color palette, but this no longer works as a side effect of a
console color map bug being fixed a while ago. The solution is to replace
the logo with a new one that uses the standard VGA console palette.
- There are still some politically-incorrect (PI) logos of a penguin holding
a glass of beer or wine (or perhaps even worse? :-).
Changes:
1. Update the frame buffer console code to no longer change the palette when
displaying the 16 color logo. Remove the tricks to load the logo palette
in unused palette entries on displays with >= 32 colors.
2. Replace the PI 16 color Penguin-with-beer logo by a new one, derived from
the 224 color logo.
3. Remove a superfluous include from drivers/char/console.c. The logo code was
moved to drivers/video/fbcon.c a long time ago.
4. Replace the PI black & white Penguin-with-beer logo by a new one, derived
from the PostScript version on Larry Ewing's webpage.
5. Remove drivers/sgi/char/linux_logo.h (containing a PI 224 color
Penguin-with-beer logo) since it's no longer used.
6. Remove the PI black & white Penguin-with-wine logo used on SPARC and
SPARC64. Use the generic logo instead.
7. Move linux_logo_* prototypes to <linux/linux_logo.h>.
8. Simplify the logo selection logic in arch-specific <asm-xxx/linux_logo.h>.
If you want to have an arch-specific logo, #define ARCH_LINUX_LOGO* and
declare your data (if INCLUDE_LINUX_LOGO_DATA is defined).
Changes 1, 2 and 3 are already present in Alan's tree.
Change 5 is already present in the Linux/MIPS CVS tree.
Patches (for both 2.4.3-pre3 and 2.4.2-ac14) can be downloaded from:
http://home.tvd.be/cr26864/Linux/fbdev/logo.html
This page also shows the old and new logos, and includes a tool to extract
logos in PNM format from the kernel sources (in case you don't trust me :-).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Thu, 8 Mar 2001, Geert Uytterhoeven wrote:
> - There are still some politically-incorrect (PI) logos of a penguin holding
> a glass of beer or wine (or perhaps even worse? :-).
Heh. Those are cool. Don't remove them. The Windoze people always look
jealous at the beer tux... :-)
Simon
--
GPG public key available from http://phobos.fs.tum.de/pgp/Simon.Richter.asc
Fingerprint: DC26 EB8D 1F35 4F44 2934 7583 DBB6 F98D 9198 3292
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!
On Thu, 8 Mar 2001, Geert Uytterhoeven wrote:
> Patches (for both 2.4.3-pre3 and 2.4.2-ac14) can be downloaded from:
>
> http://home.tvd.be/cr26864/Linux/fbdev/logo.html
>
> This page also shows the old and new logos, and includes a tool to extract
> logos in PNM format from the kernel sources (in case you don't trust me :-).
There's still some aliasing outlines on a bunch of them and I'm a bit
puzzled why there's an SGI logo on the MIPS penguin but not on the SGI
penguin.
Ideally, it'd be preferable to have .pnms in the source and a quick prog
in tools/ to build the include files as part of the makefile. Source
should be editable.
While I'm at it, may I suggest trading the gray background for black with
the penguin surrounded by a halo effect? It enhances his already, erm,
Buddha-esque appearance, to say nothing of "holy penguin pee".
--
"Love the dolphins," she advised him. "Write by W.A.S.T.E.."
Geert Uytterhoeven writes:
> - The colors for the 16 color logo are wrong. We used a hack to
> give the logo its own color palette, but this no longer works
> as a side effect of a console color map bug being fixed a while
> ago. The solution is to replace the logo with a new one that
> uses the standard VGA console palette.
Good idea, but the feet don't look too good. Either dither a bit,
or pick a single color for the feet. Maybe a checkerboard-dither
would get close to the right color without looking grainy.
> - There are still some politically-incorrect (PI) logos of a penguin
> holding a glass of beer or wine (or perhaps even worse? :-).
Those also just look bad. The drink sort of floats above the penguin's
foot. It really looks like it was just pasted onto the image.
The arch-specific logos look bad in general, and the swirly gray
background isn't so great either. Why not use the original image?
> Changes:
> 1. Update the frame buffer console code to no longer change the
> palette when displaying the 16 color logo. Remove the tricks
> to load the logo palette in unused palette entries on displays
> with >= 32 colors.
I used to have only 256 colors on my display. I upgraded because
there still isn't a global system palette. I'd have been happy
enough with 256 colors allocated in a sane way, for kernel & X:
1. the 16 VGA colors and extra 4 Windows colors (so Wine can work)
2. the 216 Netscape colors
3. gray: 0x00, 0x11, 0x22... 0xff, plus both 0x7f and 0x80
4. everything else reserved for future global allocation
The current situation is way too painful to use.
"Albert D. Cahalan" wrote:
>
> Geert Uytterhoeven writes:
>
> > - The colors for the 16 color logo are wrong. We used a hack to
> > give the logo its own color palette, but this no longer works
> > as a side effect of a console color map bug being fixed a while
> > ago. The solution is to replace the logo with a new one that
> > uses the standard VGA console palette.
>
> Good idea, but the feet don't look too good. Either dither a bit,
> or pick a single color for the feet. Maybe a checkerboard-dither
> would get close to the right color without looking grainy.
>
> > - There are still some politically-incorrect (PI) logos of a penguin
> > holding a glass of beer or wine (or perhaps even worse? :-).
>
> Those also just look bad. The drink sort of floats above the penguin's
> foot. It really looks like it was just pasted onto the image.
>
> The arch-specific logos look bad in general, and the swirly gray
> background isn't so great either. Why not use the original image?
I agree fully about the swirly gray - it's just looks ugly chlidish,
dilletantic
and very tasteless... plain color or some gui alike border would look
much better.
>
> > Changes:
> > 1. Update the frame buffer console code to no longer change the
> > palette when displaying the 16 color logo. Remove the tricks
> > to load the logo palette in unused palette entries on displays
> > with >= 32 colors.
>
> I used to have only 256 colors on my display. I upgraded because
> there still isn't a global system palette. I'd have been happy
> enough with 256 colors allocated in a sane way, for kernel & X:
>
> 1. the 16 VGA colors and extra 4 Windows colors (so Wine can work)
> 2. the 216 Netscape colors
> 3. gray: 0x00, 0x11, 0x22... 0xff, plus both 0x7f and 0x80
> 4. everything else reserved for future global allocation
>
> The current situation is way too painful to use.