2004-10-30 07:23:32

by Adrian Bunk

Subject: RFC: [2.6 patch] Eicon: disable debuglib for modules

Is there a good reason why debuglib is enabled for modules?

If not, I'd propose the patch below to disable it.


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h.old 2004-10-30 08:39:51.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h 2004-10-30 08:40:28.000000000 +0200
@@ -35,10 +35,8 @@

#include "cardtype.h"

-/* activate debuglib for modules only */
-#ifndef MODULE
+/* disable debuglib */
#define DIVA_NO_DEBUGLIB
-#endif

#define DIVA_INIT_FUNCTION __init
#define DIVA_EXIT_FUNCTION __exit

2004-10-30 11:48:45

by Armin Schindler

Subject: Re: RFC: [2.6 patch] Eicon: disable debuglib for modules

On Sat, 30 Oct 2004, Adrian Bunk wrote:
> Is there a good reason why debuglib is enabled for modules?

Yes.
Without it, there would be no possibility to use the maintainance module
to debug the isdn/card/capi interaction.

> If not, I'd propose the patch below to disable it.

I have to disagree. This patch would disable a major feature of the
diva driver collection.

Armin

> Signed-off-by: Adrian Bunk <[email protected]>
>
> --- linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h.old 2004-10-30 08:39:51.000000000 +0200
> +++ linux-2.6.10-rc1-mm2-full/drivers/isdn/hardware/eicon/platform.h 2004-10-30 08:40:28.000000000 +0200
> @@ -35,10 +35,8 @@
>
> #include "cardtype.h"
>
> -/* activate debuglib for modules only */
> -#ifndef MODULE
> +/* disable debuglib */
> #define DIVA_NO_DEBUGLIB
> -#endif
>
> #define DIVA_INIT_FUNCTION __init
> #define DIVA_EXIT_FUNCTION __exit
>

2005-02-09 13:57:45

by Armin Schindler

Subject: Re: RFC: [2.6 patch] Eicon: disable debuglib for modules

On Mon, 20 Dec 2004, Adrian Bunk wrote:
> > > Is there a good reason why debuglib is enabled for modules?
> >
> > Yes.
> > Without it, there would be no possibility to use the maintainance module
> > to debug the isdn/card/capi interaction.
> >
> > > If not, I'd propose the patch below to disable it.
> >
> > I have to disagree. This patch would disable a major feature of the
> > diva driver collection.
>
> How do I enable this maintainance module in the kernel?

In the 'ISDN active card' 'Eicon' section you will find the option
DIVA Maint driver support
which is only available as a module.
When the other diva drivers are compiled as modules too, they will provide
all trace data to the maint module.
The userspace tool 'divactrl' then retrieves the trace data according to
set trace masks.

Armin