2001-04-30 22:43:21

by Kai Germaschewski

[permalink] [raw]
Subject: [PATCH] compilation warning fixes


Newer gcc's (particularly the RH 7.0/7.1 2.96 versions) complain about
implicit declaration of the function abs, and AFAICS they're right.

What do people think about the appended patch to fix this?
(There's more users than just isdn_audio.c, that's why I added a common
header file).

--Kai

Index: linux_2_4/drivers/isdn/isdn_audio.c
diff -u linux_2_4/drivers/isdn/isdn_audio.c:1.1.1.1 linux_2_4/drivers/isdn/isdn_audio.c:1.1.1.1.26.1
--- linux_2_4/drivers/isdn/isdn_audio.c:1.1.1.1 Tue Apr 24 00:13:47 2001
+++ linux_2_4/drivers/isdn/isdn_audio.c Mon Apr 30 21:42:11 2001
@@ -25,6 +25,7 @@
#define __NO_VERSION__
#include <linux/module.h>
#include <linux/isdn.h>
+#include <linux/stdlib.h>
#include "isdn_audio.h"
#include "isdn_common.h"

Index: linux_2_4/include/linux/stdlib.h
diff -u /dev/null linux_2_4/include/linux/stdlib.h:1.1.4.3
--- /dev/null Mon Apr 30 23:28:11 2001
+++ linux_2_4/include/linux/stdlib.h Mon Apr 30 23:27:46 2001
@@ -0,0 +1,6 @@
+#ifndef __STDLIB_H__
+#define __STDLIB_H__
+
+extern int abs (int i);
+
+#endif