2001-11-10 20:11:56

by Mario 'BitKoenig' Holbe

Subject: isdn: isdnloop support crashes kernel when compiled in

Hoi,

The isdnloop support for the ISDN subsystem crashes the kernel when
compiled in the kernel directly (null pointer reference).
I guess, this is because parameters are only given as MODULE_PARM().

I found that in the 2.4.12 kernel, if it's fixed already in higher
kernels, please excuse me :)

If this is a feature and not a bug, should'nt it then be forced
to be configured as a module in the Config.in?


PS: I'm not member on the linux-kernel@ list, so please CC me in
replies, thanks.


regards,
Mario
--
*axiom* welcher sensorische input bewirkte die output-aktion,
den irc-chatter mit dem nick "dus" des irc-servers
mittels eines kills zu verweisen?

2001-11-11 12:56:16

by Kai Germaschewski

Subject: Re: isdn: isdnloop support crashes kernel when compiled in

On Sat, 10 Nov 2001, Mario 'BitKoenig' Holbe wrote:

> The isdnloop support for the ISDN subsystem crashes the kernel when
> compiled in the kernel directly (null pointer reference).
> I guess, this is because parameters are only given as MODULE_PARM().
>
> I found that in the 2.4.12 kernel, if it's fixed already in higher
> kernels, please excuse me :)
>
> If this is a feature and not a bug, should'nt it then be forced
> to be configured as a module in the Config.in?

It's a bug. The appended patch should fix it.

--Kai

diff -ur linux-2.4.15-pre2.patches/drivers/isdn/isdnloop/isdnloop.c linux-2.4.15-pre2.work/drivers/isdn/isdnloop/isdnloop.c
--- linux-2.4.15-pre2.patches/drivers/isdn/isdnloop/isdnloop.c Sun Oct 21 00:17:11 2001
+++ linux-2.4.15-pre2.work/drivers/isdn/isdnloop/isdnloop.c Sun Nov 11 13:37:36 2001
@@ -1542,7 +1542,11 @@
} else
strcpy(rev, " ??? ");
printk(KERN_NOTICE "isdnloop-ISDN-driver Rev%s\n", rev);
- return (isdnloop_addcard(isdnloop_id));
+
+ if (isdnloop_id)
+ return (isdnloop_addcard(isdnloop_id));
+
+ return 0;
}

static void __exit