2002-01-05 07:54:48

by Adam J. Richter

[permalink] [raw]
Subject: Patch: linux-2.5.2-pre8/drivers/isdn/sc/commands.c bug exposed by kdev_t changes


The kdev_t changes have exposed an amusing bug in
linux-2.5.2-pre8/drivers/isdn/sc/command.c. A routine that
was intended to return the error "-ENODEV" was actually
returning "-NODEV" (prevously zero, now a compilation error).
Here is the fix.

I have already checked to see that '-NODEV' and '- NODEV' do
not appear anywhere else in the kernel sources.

--
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
[email protected] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."


Attachments:
(No filename) (648.00 B)
sc.diff (252.00 B)
Download all attachments

2002-01-05 11:05:12

by Kai Germaschewski

[permalink] [raw]
Subject: Re: Patch: linux-2.5.2-pre8/drivers/isdn/sc/commands.c bug exposed by kdev_t changes

On Fri, 4 Jan 2002, Adam J. Richter wrote:

> The kdev_t changes have exposed an amusing bug in
> linux-2.5.2-pre8/drivers/isdn/sc/command.c. A routine that
> was intended to return the error "-ENODEV" was actually
> returning "-NODEV" (prevously zero, now a compilation error).
> Here is the fix.

Looks good.

Attached again for easier applying.

--Kai

--- linux-2.5.2-pre8/drivers/isdn/sc/command.c Sun Sep 30 12:26:06 2001
+++ linux/drivers/isdn/sc/command.c Fri Jan 4 23:47:36 2002
@@ -95,7 +95,7 @@
if(adapter[i]->driverId == driver)
return i;
}
- return -NODEV;
+ return -ENODEV;
}

/*