2002-01-10 20:28:18

by Peter Jones

[permalink] [raw]
Subject: [PATCH] #ifdef __cplusplus removal (fwd)

And again for my bad email aliases :)

--
Peter

---------- Forwarded message ----------
Date: Thu, 10 Jan 2002 15:23:09 -0500 (EST)
From: Peter Jones <[email protected]>
To: [email protected], [email protected]
Subject: [PATCH] #ifdef __cplusplus removal

Marcello,

This patch removes the "#ifdef __cplusplus" from within a "#ifdef
__KERNEL__" in linux/string.h. It really isn't needed AFACIT. It was put
in for 1.1.0, which was before __KERNEL__ appeared. Alan told me to send
it to you.

--- linux/include/linux/string.h.orig Thu Jan 10 01:14:48 2002
+++ linux/include/linux/string.h Thu Jan 10 01:14:50 2002
@@ -8,10 +8,6 @@
#include <linux/types.h> /* for size_t */
#include <linux/stddef.h> /* for NULL */

-#ifdef __cplusplus
-extern "C" {
-#endif
-
extern char * ___strtok;
extern char * strpbrk(const char *,const char *);
extern char * strtok(char *,const char *);
@@ -78,10 +74,6 @@
#endif
#ifndef __HAVE_ARCH_MEMCHR
extern void * memchr(const void *,int,__kernel_size_t);
-#endif
-
-#ifdef __cplusplus
-}
#endif

#endif

--
Peter






2002-01-10 20:41:30

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH] #ifdef __cplusplus removal (fwd)

On Thu, 10 Jan 2002, Peter Jones wrote:

> And again for my bad email aliases :)
> This patch removes the "#ifdef __cplusplus" from within a "#ifdef
> __KERNEL__" in linux/string.h. It really isn't needed AFACIT. It was
> put
> in for 1.1.0, which was before __KERNEL__ appeared. Alan told me to
> send it to you.

A quick grep shows __cplusplus is used in quite a few places in the kernel
source. I'm wondering if various developers are running their code through
g++ to maybe pick up on warnings that gcc doesn't see.

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs

2002-01-10 20:43:21

by Peter Jones

[permalink] [raw]
Subject: Re: [PATCH] #ifdef __cplusplus removal (fwd)

On Thu, 10 Jan 2002, Dave Jones wrote:

> On Thu, 10 Jan 2002, Peter Jones wrote:
>
> > And again for my bad email aliases :)
> > This patch removes the "#ifdef __cplusplus" from within a "#ifdef
> > __KERNEL__" in linux/string.h. It really isn't needed AFACIT. It was
> > put
> > in for 1.1.0, which was before __KERNEL__ appeared. Alan told me to
> > send it to you.
>
> A quick grep shows __cplusplus is used in quite a few places in the kernel
> source. I'm wondering if various developers are running their code through
> g++ to maybe pick up on warnings that gcc doesn't see.

That was the only one I saw in include/linux that was inside __KERNEL__ .

I didn't look in include/asm* carefully, but grep found some __cplusplus
code there as well.

--
Peter