2002-01-30 22:15:10

by Pawel Worach

[permalink] [raw]
Subject: 2.5.3 won't compile (i810_audio)

The new i810_audio driver merged into 2.5.3 won't compile.
Here is the result:

gcc -D__KERNEL__ -I/usr/src/kernel/2.5/linux/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i686 -DMODULE -c -o i810_audio.o i810_audio.c
i810_audio.c: In function `i810_mmap':
i810_audio.c:1673: warning: passing arg 1 of `remap_page_range' makes
pointer from integer without a cast
i810_audio.c:1673: incompatible type for argument 4 of `remap_page_range'
i810_audio.c:1673: too few arguments to function `remap_page_range'
make[2]: *** [i810_audio.o] Error 1

../Pawel


2002-01-31 02:33:25

by Ben Clifford

[permalink] [raw]
Subject: Re: 2.5.3 won't compile (i810_audio)

On Wed, 30 Jan 2002, Pawel Worach wrote:

> The new i810_audio driver merged into 2.5.3 won't compile.

I made the following one line change, and it seems to be working.

--- drivers/sound/i810_audio.c-src Wed Jan 30 18:30:51 2002
+++ drivers/sound/i810_audio.c Wed Jan 30 18:22:39 2002
@@ -1669,7 +1669,7 @@
if (size > (PAGE_SIZE << dmabuf->buforder))
goto out;
ret = -EAGAIN;
- if (remap_page_range(vma->vm_start, virt_to_phys(dmabuf->rawbuf),
+ if (remap_page_range(vma, vma->vm_start, virt_to_phys(dmabuf->rawbuf),
size, vma->vm_page_prot))
goto out;
dmabuf->mapped = 1;


--
Ben Clifford [email protected] GPG: 30F06950
Job Required in Los Angeles - Will do most things unix or IP for money.
http://www.hawaga.org.uk/resume/resume001.pdf
Live Ben-cam: http://barbarella.hawaga.org.uk/benc-cgi/watchers.cgi