Hello everybody. The following extract from
drivers/input/gameport/Config.in doesn't seem quite right to me, in
general and for ARM specifically:
if [ "$CONFIG_GAMEPORT" = "m" ]; then
define_tristate CONFIG_SOUND_GAMEPORT m
fi
if [ "$CONFIG_GAMEPORT" != "m" ]; then
define_tristate CONFIG_SOUND_GAMEPORT y
fi
Could the maintainer please change this?
Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany
On Wed, Mar 13, 2002 at 04:27:49PM +0100, Guennadi Liakhovetski wrote:
> Hello everybody. The following extract from
> drivers/input/gameport/Config.in doesn't seem quite right to me, in
> general and for ARM specifically:
> if [ "$CONFIG_GAMEPORT" = "m" ]; then
> define_tristate CONFIG_SOUND_GAMEPORT m
> fi
> if [ "$CONFIG_GAMEPORT" != "m" ]; then
> define_tristate CONFIG_SOUND_GAMEPORT y
> fi
>
> Could the maintainer please change this?
What's the problem here?
--
Vojtech Pavlik
SuSE Labs
> > drivers/input/gameport/Config.in doesn't seem quite right to me, in
> > general and for ARM specifically:
> > if [ "$CONFIG_GAMEPORT" = "m" ]; then
> > define_tristate CONFIG_SOUND_GAMEPORT m
> > fi
> > if [ "$CONFIG_GAMEPORT" != "m" ]; then
> > define_tristate CONFIG_SOUND_GAMEPORT y
> > fi
> >
> > Could the maintainer please change this?
>
> What's the problem here?
The problem is, that if you don't have anything like a sound-card/gameport
at all, CONFIG_SOUND_GAMEPORT still will be YES. Ok, I didn't check in the
code, maybe it doesn't add a single byte to the kernel, .config looks a
bit confusing, doesn't it?
Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany
On Thu, Mar 14, 2002 at 09:12:04AM +0100, Guennadi Liakhovetski wrote:
> > > drivers/input/gameport/Config.in doesn't seem quite right to me, in
> > > general and for ARM specifically:
> > > if [ "$CONFIG_GAMEPORT" = "m" ]; then
> > > define_tristate CONFIG_SOUND_GAMEPORT m
> > > fi
> > > if [ "$CONFIG_GAMEPORT" != "m" ]; then
> > > define_tristate CONFIG_SOUND_GAMEPORT y
> > > fi
> > >
> > > Could the maintainer please change this?
> >
> > What's the problem here?
>
> The problem is, that if you don't have anything like a sound-card/gameport
> at all, CONFIG_SOUND_GAMEPORT still will be YES. Ok, I didn't check in the
> code, maybe it doesn't add a single byte to the kernel, .config looks a
> bit confusing, doesn't it?
Yes, it doesn't add anything. It's just a switch that *disables*
gameport code in sound drivers if no gameport support is selected in the
kernel.
--
Vojtech Pavlik
SuSE Labs
On Thu, Mar 14, 2002 at 10:07:22AM +0100, Guennadi Liakhovetski wrote:
> > > The problem is, that if you don't have anything like a sound-card/gameport
> > > at all, CONFIG_SOUND_GAMEPORT still will be YES. Ok, I didn't check in the
> > > code, maybe it doesn't add a single byte to the kernel, .config looks a
> > > bit confusing, doesn't it?
> >
> > Yes, it doesn't add anything. It's just a switch that *disables*
> > gameport code in sound drivers if no gameport support is selected in the
> > kernel.
>
> Sorry, did I get it right - if it is set to "yes", then it DISABLES
> gameport code?... Hm... Ok, as long as it doesn't add anything, I better
> shut up now, but, seems to me, it does look confusing...
No, if it is set to yes, it allows the gameport code in the sound
drivers. If set to no, it disables it. All only if the sound drivers
which have gameport code in them are enabled.
--
Vojtech Pavlik
SuSE Labs
> > The problem is, that if you don't have anything like a sound-card/gameport
> > at all, CONFIG_SOUND_GAMEPORT still will be YES. Ok, I didn't check in the
> > code, maybe it doesn't add a single byte to the kernel, .config looks a
> > bit confusing, doesn't it?
>
> Yes, it doesn't add anything. It's just a switch that *disables*
> gameport code in sound drivers if no gameport support is selected in the
> kernel.
Sorry, did I get it right - if it is set to "yes", then it DISABLES
gameport code?... Hm... Ok, as long as it doesn't add anything, I better
shut up now, but, seems to me, it does look confusing...
Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany