2002-10-21 19:06:29

by Sam Ravnborg

[permalink] [raw]
Subject: sound/core/wrappers.c __GENKSYMS__ usage

Hi Jaroslav

The usage of __GENKSYMS__ in sound/core/wrappers.c looks wrong.

>From the file:
#include <linux/version.h>
#include <linux/config.h>
#ifdef ALSA_BUILD
#if defined(CONFIG_MODVERSIONS) && !defined(__GENKSYMS__) && !defined(__DEPEND__)
#define MODVERSIONS
#include <linux/modversions.h>
#include "sndversions.h"
#endif
#endif

So __GENKSYMS__ etc is used to protect against inclusion of modversions.h
and sndversion.h.
The latter is not present in my tree (2.5.44).
__DEPEND__ is no longer used.

I do not see the purpose of this - please explain.

Sam


2002-10-22 10:38:36

by Jaroslav Kysela

[permalink] [raw]
Subject: Re: sound/core/wrappers.c __GENKSYMS__ usage

On Mon, 21 Oct 2002, Sam Ravnborg wrote:

> Hi Jaroslav
>
> The usage of __GENKSYMS__ in sound/core/wrappers.c looks wrong.
>
> >From the file:
> #include <linux/version.h>
> #include <linux/config.h>
> #ifdef ALSA_BUILD
> #if defined(CONFIG_MODVERSIONS) && !defined(__GENKSYMS__) && !defined(__DEPEND__)
> #define MODVERSIONS
> #include <linux/modversions.h>
> #include "sndversions.h"
> #endif
> #endif
>
> So __GENKSYMS__ etc is used to protect against inclusion of modversions.h
> and sndversion.h.
> The latter is not present in my tree (2.5.44).
> __DEPEND__ is no longer used.
>
> I do not see the purpose of this - please explain.

It's for compatibility with older kernels. We use same sources for 2.2 and
2.4 kernels. Also notice that "problematic" #if is after ALSA_BUILD and
it's not defined for Linux kernel (we use this definition internally for
our build system).

Anyway, I'll move this code outside the kernel tree.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com