2005-01-25 05:04:04

by Bryce Harrington

[permalink] [raw]
Subject: Re: [[email protected]: Re: Memory leak in 2.6.11-rc1?]

Hi Chris,

I applied the patch and reran the test on a RH 9.0 system. LTP is
continuing past where it failed before, and processes are not getting
killed, so I assume the OOM killer is no longer getting activated.

There is a new behavior, though. Now the test is hanging indefinitely
on the nptl01 test. I am assuming that since it passed the spot that it
had failed before, that this is an unrelated issue.

Bryce


On Mon, 24 Jan 2005, Chris Wright wrote:
> Any chance you could re-try with this patch applied?
>
> ----- Forwarded message from Linus Torvalds <[email protected]> -----
>
> Date: Mon, 24 Jan 2005 14:35:47 -0800 (PST)
> From: Linus Torvalds <[email protected]>
> To: Andrew Morton <[email protected]>
> cc: Jens Axboe <[email protected]>, [email protected], [email protected],
> [email protected], [email protected]
> Subject: Re: Memory leak in 2.6.11-rc1?
>
>
>
> On Mon, 24 Jan 2005, Andrew Morton wrote:
> >
> > Would indicate that the new pipe code is leaking.
>
> Duh. It's the pipe merging.
>
> Linus
>
> ----
> --- 1.40/fs/pipe.c 2005-01-15 12:01:16 -08:00
> +++ edited/fs/pipe.c 2005-01-24 14:35:09 -08:00
> @@ -630,13 +630,13 @@
> struct pipe_inode_info *info = inode->i_pipe;
>
> inode->i_pipe = NULL;
> - if (info->tmp_page)
> - __free_page(info->tmp_page);
> for (i = 0; i < PIPE_BUFFERS; i++) {
> struct pipe_buffer *buf = info->bufs + i;
> if (buf->ops)
> buf->ops->release(info, buf);
> }
> + if (info->tmp_page)
> + __free_page(info->tmp_page);
> kfree(info);
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
> ----- End forwarded message -----
>
>




2005-01-25 07:19:07

by Andrew Morton

[permalink] [raw]
Subject: Re: [[email protected]: Re: Memory leak in 2.6.11-rc1?]

Bryce Harrington <[email protected]> wrote:
>
> There is a new behavior, though. Now the test is hanging indefinitely
> on the nptl01 test. I am assuming that since it passed the spot that it
> had failed before, that this is an unrelated issue.

I'm finding that nptl01 somtimes gets stuck and sometimes works OK. Try
running it by hand a few times.

It could be an application bug or a kernel bug.

2005-01-25 17:43:51

by Bryce Harrington

[permalink] [raw]
Subject: Re: [[email protected]: Re: Memory leak in 2.6.11-rc1?]

On Mon, 24 Jan 2005, Andrew Morton wrote:
> Bryce Harrington <[email protected]> wrote:
> >
> > There is a new behavior, though. Now the test is hanging indefinitely
> > on the nptl01 test. I am assuming that since it passed the spot that it
> > had failed before, that this is an unrelated issue.
>
> I'm finding that nptl01 somtimes gets stuck and sometimes works OK. Try
> running it by hand a few times.
>
> It could be an application bug or a kernel bug.

Okay, so it doesn't sound like anything to be worried about.

Thanks,
Bryce

2005-01-25 18:25:07

by Andrew Morton

[permalink] [raw]
Subject: Re: [[email protected]: Re: Memory leak in 2.6.11-rc1?]

Bryce Harrington <[email protected]> wrote:
>
> On Mon, 24 Jan 2005, Andrew Morton wrote:
> > Bryce Harrington <[email protected]> wrote:
> > >
> > > There is a new behavior, though. Now the test is hanging indefinitely
> > > on the nptl01 test. I am assuming that since it passed the spot that it
> > > had failed before, that this is an unrelated issue.
> >
> > I'm finding that nptl01 somtimes gets stuck and sometimes works OK. Try
> > running it by hand a few times.
> >
> > It could be an application bug or a kernel bug.
>
> Okay, so it doesn't sound like anything to be worried about.
>

Well no. If we're sure that kernel changes caused this new behaviour then
that's a problem.