2002-01-24 06:35:10

by Zwane Mwaikambo

Subject: [PATCH][2.5] Fix block backed loop mounts

Hi Jens,
This is a patch which Adam Richter posted sometime back, it still
hasn't been integrated as of 2.5.3-pre3. I've tested the patch on my box
and vote for it, it applies clean on 2.5.3-pre3.

Regards,
Zwane Mwaikambo


--- linux-2.5.2-pre11/drivers/block/loop.c Mon Jan 14 05:48:01 2002
+++ linux/drivers/block/loop.c Mon Jan 14 06:13:33 2002
@@ -488,15 +488,15 @@
struct bio *rbh)
{
unsigned long IV = loop_get_iv(lo, rbh->bi_sector);
- struct bio_vec *to;
+ struct bio_vec *from;
char *vto, *vfrom;
int ret = 0, i;

- bio_for_each_segment(to, bio, i) {
- vfrom = page_address(rbh->bi_io_vec[i].bv_page) + rbh->bi_io_vec[i].bv_offset;
- vto = page_address(to->bv_page) + to->bv_offset;
+ bio_for_each_segment(from, rbh, i) {
+ vfrom = page_address(from->bv_page) + from->bv_offset;
+ vto = page_address(bio->bi_io_vec[i].bv_page) + bio->bi_io_vec[i].bv_offset;
ret |= lo_do_transfer(lo, bio_data_dir(bio), vto, vfrom,
- to->bv_len, IV);
+ from->bv_len, IV);
}

return ret;

2002-01-24 07:01:15

by Adam J. Richter

Subject: Re: [PATCH][2.5] Fix block backed loop mounts

Thank you for picking up this patch and resubmitting it. I
don't think anyone had any complaints about it before. I was
wondering if it had fallen through the cracks. Jens, do you want to
integrate this patch into whatever you are sending to Linus, or should
Zwane or I needle Linus directly about it?

Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
[email protected] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."


>From: Zwane Mwaikambo <[email protected]>
>To: Jens Axboe <[email protected]>

>Hi Jens,
> This is a patch which Adam Richter posted sometime back, it still
>hasn't been integrated as of 2.5.3-pre3. I've tested the patch on my box
>and vote for it, it applies clean on 2.5.3-pre3.

>Regards,
> Zwane Mwaikambo


--- linux-2.5.2-pre11/drivers/block/loop.c Mon Jan 14 05:48:01 2002
+++ linux/drivers/block/loop.c Mon Jan 14 06:13:33 2002
@@ -488,15 +488,15 @@
struct bio *rbh)
{
unsigned long IV = loop_get_iv(lo, rbh->bi_sector);
- struct bio_vec *to;
+ struct bio_vec *from;
char *vto, *vfrom;
int ret = 0, i;

- bio_for_each_segment(to, bio, i) {
- vfrom = page_address(rbh->bi_io_vec[i].bv_page) + rbh->bi_io_vec[i].bv_offset;
- vto = page_address(to->bv_page) + to->bv_offset;
+ bio_for_each_segment(from, rbh, i) {
+ vfrom = page_address(from->bv_page) + from->bv_offset;
+ vto = page_address(bio->bi_io_vec[i].bv_page) + bio->bi_io_vec[i].bv_offset;
ret |= lo_do_transfer(lo, bio_data_dir(bio), vto, vfrom,
- to->bv_len, IV);
+ from->bv_len, IV);
}

return ret;

2002-01-24 07:03:34

by Jens Axboe

Subject: Re: [PATCH][2.5] Fix block backed loop mounts

On Wed, Jan 23 2002, Adam J. Richter wrote:
> Thank you for picking up this patch and resubmitting it. I
> don't think anyone had any complaints about it before. I was
> wondering if it had fallen through the cracks. Jens, do you want to
> integrate this patch into whatever you are sending to Linus, or should
> Zwane or I needle Linus directly about it?

Just go ahead and send it to Linus, I'm fine with the patch.

--
Jens Axboe