Hey,
something fun for you all...
thanks,
/ Brett
gcc -D__KERNEL__ -I/usr/src/linux-2.5.5-dj2/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i586 -DMODULE -DMODVERSIONS -include
/usr/src/linux-2.5.5-dj2/include/linux/modversions.h
-DKBUILD_BASENAME=opl3sa2 -c -o opl3sa2.o opl3sa2.c
opl3sa2.c: In function `opl3sa2_pm_callback':
opl3sa2.c:979: warning: cast from pointer to integer of different size
opl3sa2.c: In function `cleanup_opl3sa2':
opl3sa2.c:1143: `opl3sa2_data' undeclared (first use in this function)
opl3sa2.c:1143: (Each undeclared identifier is reported only once
opl3sa2.c:1143: for each function it appears in.)
opl3sa2.c:1146: `cfg_mpu' undeclared (first use in this function)
make[2]: *** [opl3sa2.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.5.5-dj2/sound/oss'
make[1]: *** [_modsubdir_oss] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.5-dj2/sound'
make: *** [_mod_sound] Error 2
On Wed, 27 Feb 2002, Brett wrote:
>
> Hey,
>
> something fun for you all...
Thanks i'll fix it and send in a patch.
Zwane
On Wed, 27 Feb 2002, Zwane Mwaikambo wrote:
> On Wed, 27 Feb 2002, Brett wrote:
>
> >
> > Hey,
> >
> > something fun for you all...
>
> Thanks i'll fix it and send in a patch.
>
> Zwane
Zwane, you might as well submit a patch against MAINTAINERS since you've
been performing the role for several months now. I'm up to my ears in
work and I really don't foresee having the time to look into any issues
with the opl3sa2 driver for quite a while.
Thanks,
Scott (aka [email protected])
--
Scott Murray
SOMA Networks, Inc.
Toronto, Ontario
e-mail: [email protected]
On Wed, 27 Feb 2002, Brett wrote:
>
> Hey,
>
> something fun for you all...
Here you go, don't know how that slipped by ^_^
Regards,
Zwane
Diffed against 2.5.5-dj2
--- linux-2.5.5-pre1/sound/oss/opl3sa2.c.orig Wed Feb 27 15:43:25 2002
+++ linux-2.5.5-pre1/sound/oss/opl3sa2.c Wed Feb 27 15:45:12 2002
@@ -1140,11 +1140,11 @@
for(card = 0; card < opl3sa2_cards_num; card++) {
#ifdef CONFIG_PM
- if (opl3sa2_data[card].pmdev)
- pm_unregister(opl3sa2_data[card].pmdev);
+ if (opl3sa2_state[card].pmdev)
+ pm_unregister(opl3sa2_state[card].pmdev);
#endif
- if(cfg_mpu[card].slots[1] != -1) {
- unload_opl3sa2_mpu(&cfg_mpu[card]);
+ if(opl3sa2_state[card].cfg_mpu.slots[1] != -1) {
+ unload_opl3sa2_mpu(&opl3sa2_state[card].cfg_mpu);
}
unload_opl3sa2_mss(&opl3sa2_state[card].cfg_mss);
unload_opl3sa2(&opl3sa2_state[card].cfg, card);