Hi, Marcelo. The last few pre-patches have broken IDE as modules. I
would have though this would have been fixed by now, but perhaps
no-one else noticed. Here is a patch that fixes the problem.
Regards,
Richard....
Permanent: [email protected]
Current: [email protected]
diff -urN linux-2.4.19-pre6/drivers/ide/ide-probe.c linux/drivers/ide/ide-probe.c
--- linux-2.4.19-pre6/drivers/ide/ide-probe.c Sat Apr 6 14:15:17 2002
+++ linux/drivers/ide/ide-probe.c Sun Apr 14 15:51:51 2002
@@ -987,7 +987,6 @@
}
#ifdef MODULE
-extern int (*ide_xlate_1024_hook)(kdev_t, int, int, const char *);
int init_module (void)
{
@@ -997,14 +996,12 @@
ide_unregister(index);
ideprobe_init();
create_proc_ide_interfaces();
- ide_xlate_1024_hook = ide_xlate_1024;
return 0;
}
void cleanup_module (void)
{
ide_probe = NULL;
- ide_xlate_1024_hook = 0;
}
MODULE_LICENSE("GPL");
#endif /* MODULE */
On Sun, 14 Apr 2002, Richard Gooch wrote:
> Hi, Marcelo. The last few pre-patches have broken IDE as modules. I
> would have though this would have been fixed by now, but perhaps
> no-one else noticed. Here is a patch that fixes the problem.
Richard, I agree with you that seems like nobody cared. I had submitted
this patch several times, but it's still not fixed.
Jeff.
Well I sent the rest of the patch in that got lost.
It is the fs/* directory that is missing things.
There was a decouple of code from 2.4.X-ac to marcelo.
Cheers,
Andre Hedrick
LAD Storage Consulting Group
On Sun, 14 Apr 2002, Richard Gooch wrote:
> Hi, Marcelo. The last few pre-patches have broken IDE as modules. I
> would have though this would have been fixed by now, but perhaps
> no-one else noticed. Here is a patch that fixes the problem.
>
> Regards,
>
> Richard....
> Permanent: [email protected]
> Current: [email protected]
>
> diff -urN linux-2.4.19-pre6/drivers/ide/ide-probe.c linux/drivers/ide/ide-probe.c
> --- linux-2.4.19-pre6/drivers/ide/ide-probe.c Sat Apr 6 14:15:17 2002
> +++ linux/drivers/ide/ide-probe.c Sun Apr 14 15:51:51 2002
> @@ -987,7 +987,6 @@
> }
>
> #ifdef MODULE
> -extern int (*ide_xlate_1024_hook)(kdev_t, int, int, const char *);
>
> int init_module (void)
> {
> @@ -997,14 +996,12 @@
> ide_unregister(index);
> ideprobe_init();
> create_proc_ide_interfaces();
> - ide_xlate_1024_hook = ide_xlate_1024;
> return 0;
> }
>
> void cleanup_module (void)
> {
> ide_probe = NULL;
> - ide_xlate_1024_hook = 0;
> }
> MODULE_LICENSE("GPL");
> #endif /* MODULE */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Here is the original patch from its base, and the lost fragment.
Cheers,
Andre Hedrick
LAD Storage Consulting Group
On Mon, 15 Apr 2002, Jeff Chua wrote:
>
> On Sun, 14 Apr 2002, Richard Gooch wrote:
>
> > Hi, Marcelo. The last few pre-patches have broken IDE as modules. I
> > would have though this would have been fixed by now, but perhaps
> > no-one else noticed. Here is a patch that fixes the problem.
>
> Richard, I agree with you that seems like nobody cared. I had submitted
> this patch several times, but it's still not fixed.
>
> Jeff.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Jeff Chua writes:
>
> On Sun, 14 Apr 2002, Richard Gooch wrote:
>
> > Hi, Marcelo. The last few pre-patches have broken IDE as modules. I
> > would have though this would have been fixed by now, but perhaps
> > no-one else noticed. Here is a patch that fixes the problem.
>
> Richard, I agree with you that seems like nobody cared. I had
> submitted this patch several times, but it's still not fixed.
Pity it hasn't been picked up yet :-(
Regards,
Richard....
Permanent: [email protected]
Current: [email protected]