2002-06-05 18:53:29

by Szabolcs Berecz

[permalink] [raw]
Subject: [PATCH] use $(CONFIG_SHELL instead of . in Makefile


sh ignores parameters when using . , so we should use $(CONFIG_SHELL)
instead.

patch is against 2.5.20

Bye,
Szabi

--- linux-2.5.20/Makefile.orig Wed Jun 5 16:34:22 2002
+++ linux-2.5.20/Makefile Wed Jun 5 16:50:18 2002
@@ -231,7 +231,7 @@

include/linux/version.h: Makefile
@echo Generating $@
- @. scripts/mkversion_h $@ $(KERNELRELEASE) $(VERSION) $(PATCHLEVEL) $(SUBLEVEL)
+ @$(CONFIG_SHELL) scripts/mkversion_h $@ $(KERNELRELEASE) $(VERSION) $(PATCHLEVEL) $(SUBLEVEL)

# Helpers built in scripts/
# ---------------------------------------------------------------------------


2002-06-06 17:21:29

by Kai Germaschewski

[permalink] [raw]
Subject: Re: [PATCH] use $(CONFIG_SHELL instead of . in Makefile

On Wed, 5 Jun 2002, Szabolcs Berecz wrote:

> sh ignores parameters when using . , so we should use $(CONFIG_SHELL)
> instead.

It's fixed differently in the latest tree (by making mkversion_h
executable and executing instead of sourcing it).

Thanks, though.

--Kai