2002-06-09 19:16:58

by Thunder from the hill

Subject: About new list commands and emu10k1

Hi,

I couldn't reach the emu10k1 guys for some obscure reason. I had a patch
which sounded like this:

--- linus-2.5/sound/pci/emu10k1/memory.c Sun Jun 9 04:18:03 2002
+++ thunder-2.5/sound/pci/emu10k1/memory.c Sun Jun 9 07:47:37 2002
@@ -259,8 +259,7 @@
spin_lock_irqsave(&emu->memblk_lock, flags);
if (blk->mapped_page >= 0) {
/* update order link */
- list_del(&blk->mapped_order_link);
- list_add_tail(&blk->mapped_order_link, &emu->mapped_order_link_head);
+ list_move_tail(&blk->mapped_order_link, &emu->mapped_order_link_head);
spin_unlock_irqrestore(&emu->memblk_lock, flags);
return 0;
}

Regards,
Thunder
--
German attitude becoming | Thunder from the hill at ngforever
rightaway popular: |
"Get outa my way, | free inhabitant not directly
for I got a mobile phone!" | belonging anywhere

2002-06-09 21:04:44

by Rui Sousa

Subject: Re: About new list commands and emu10k1

On Sun, 9 Jun 2002, Thunder from the hill wrote:


> Hi,
>
> I couldn't reach the emu10k1 guys for some obscure reason.

The maintainer file for OSS emu10k1 needs to be updated (as well as the
driver)... However _this_ emu10k1 driver is from ALSA.

Rui Sousa

> I had a patch
> which sounded like this:
>
> --- linus-2.5/sound/pci/emu10k1/memory.c Sun Jun 9 04:18:03 2002
> +++ thunder-2.5/sound/pci/emu10k1/memory.c Sun Jun 9 07:47:37 2002
> @@ -259,8 +259,7 @@
> spin_lock_irqsave(&emu->memblk_lock, flags);
> if (blk->mapped_page >= 0) {
> /* update order link */
> - list_del(&blk->mapped_order_link);
> - list_add_tail(&blk->mapped_order_link, &emu->mapped_order_link_head);
> + list_move_tail(&blk->mapped_order_link, &emu->mapped_order_link_head);
> spin_unlock_irqrestore(&emu->memblk_lock, flags);
> return 0;
> }
>
> Regards,
> Thunder
>