2002-06-20 07:15:00

by Adrian Bunk

Subject: [2.5 patch] tqueue.h fixes for ISDN

Hi Kai,

the following two tqueue.h fixes are needed to fix compile errors in the
ISDN subsystem (the error messages follow below):


--- drivers/isdn/pcbit/drv.c.old Thu Jun 20 08:55:22 2002
+++ drivers/isdn/pcbit/drv.c Thu Jun 20 08:56:17 2002
@@ -30,6 +30,7 @@
#include <linux/mm.h>
#include <linux/interrupt.h>
#include <linux/string.h>
+#include <linux/tqueue.h>
#include <linux/skbuff.h>

#include <linux/isdnif.h>
--- drivers/isdn/tpam/tpam.h.old Thu Jun 20 09:04:05 2002
+++ drivers/isdn/tpam/tpam.h Thu Jun 20 09:04:31 2002
@@ -16,6 +16,7 @@

#include <linux/isdnif.h>
#include <linux/init.h>
+#include <linux/tqueue.h>

/* Maximum number of channels for this board */
#define TPAM_NBCHANNEL 30


cu
Adrian


<-- snip -->

...
gcc -Wp,-MD,./.drv.o.d -D__KERNEL__
-I/home/bunk/linux/kernel-2.5/linux-2.5.23
/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6
-nostdinc -iwithprefix include -DKBUILD_BASENAME=drv -c -o drv.o drv.c
In file included from drv.c:40:
pcbit.h:75: field `qdelivery' has incomplete type
make[3]: *** [drv.o] Error 1
make[3]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.23/drivers/isd

<-- snip -->

...
gcc -Wp,-MD,./.tpam_memory.o.d -D__KERNEL__
-I/home/bunk/linux/kernel-2.5/linux-2.5.23/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2
-fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6
-nostdinc -iwithprefix include -DKBUILD_BASENAME=tpam_memory -c -o
tpam_memory.o tpam_memory.c
In file included from tpam_memory.c:17:
tpam.h:88: field `send_tq' has incomplete type
tpam.h:89: field `recv_tq' has incomplete type
make[3]: *** [tpam_memory.o] Error 1
make[3]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.23/drivers/isdn/tpam'

<-- snip -->

2002-06-20 14:21:39

by Kai Germaschewski

Subject: Re: [2.5 patch] tqueue.h fixes for ISDN

On Thu, 20 Jun 2002, Adrian Bunk wrote:

> the following two tqueue.h fixes are needed to fix compile errors in the
> ISDN subsystem (the error messages follow below):

Yup, you're right. I fixed those already and submitted them to Linus.
Thanks anyway, though.

--Kai