2002-07-06 17:07:59

by Thunder from the hill

Subject: inline generic_writepages(mapping,nr_to_write)?

Hi,

(I keep forgetting whom to send mm suggestions, however this is a question
for all of you.)

Now that generic_writepages() shrinked a lot, couldn't we consider making
it inline?

inline int generic_writepages(struct address_space *mapping,
int nr_to_write)
{
return mpage_writepages(mapping, nr_to_write, NULL);
}

Regards,
Thunder
--
(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o? K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y-
------END GEEK CODE BLOCK------

2002-07-06 19:55:48

by Andrew Morton

Subject: Re: inline generic_writepages(mapping,nr_to_write)?

Thunder from the hill wrote:
>
> Hi,
>
> (I keep forgetting whom to send mm suggestions, however this is a question
> for all of you.)
>
> Now that generic_writepages() shrinked a lot, couldn't we consider making
> it inline?
>
> inline int generic_writepages(struct address_space *mapping,
> int nr_to_write)
> {
> return mpage_writepages(mapping, nr_to_write, NULL);
> }
>

That would make sense.

-