2002-07-16 08:34:21

by William Lee Irwin III

Subject: NFS nonzero preempt_count 1/2

When unmounting an NFS filesystem, I saw printk's reporting that NFS
daemons exited with nonzero preempt_counts. Fixing this up so they
no longer give the warning seems like a good idea.

Patch attempting to do this for rpciod below.


Cheers,
Bill


===== net/sunrpc/sched.c 1.15 vs edited =====
--- 1.15/net/sunrpc/sched.c Fri May 3 18:52:12 2002
+++ edited/net/sunrpc/sched.c Tue Jul 16 02:00:32 2002
@@ -1088,6 +1088,7 @@
wake_up(assassin);

dprintk("RPC: rpciod exiting\n");
+ unlock_kernel();
MOD_DEC_USE_COUNT;
return 0;
}

2002-07-16 15:25:35

by Thunder from the hill

Subject: Re: NFS nonzero preempt_count 1/2

Hi,

On Tue, 16 Jul 2002, William Lee Irwin III wrote:
> @@ -1088,6 +1088,7 @@
> wake_up(assassin);
>
> dprintk("RPC: rpciod exiting\n");
> + unlock_kernel();
> MOD_DEC_USE_COUNT;
> return 0;
> }

I wonder why the checker didn't yell on this. Wasn't it in the tree when
the checker checked?

Regards,
Thunder
--
(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o? K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y-
------END GEEK CODE BLOCK------