2002-07-25 05:54:43

by A Guy Called Tyketto

[permalink] [raw]
Subject: 2.5.28: aty128fb.c:1752: incompatible type


Roll of 2.5.28:

gcc -Wp,-MD,./.aty128fb.o.d -D__KERNEL__ -I/usr/src/linux-2.5.25/include
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -g -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i686 -malign-functions=4 -nostdinc -iwithprefix include
-DKBUILD_BASENAME=aty128fb -c -o aty128fb.o aty128fb.c
aty128fb.c: In function `aty128fb_set_var':
aty128fb.c:1406: warning: implicit declaration of function `do_install_cmap'
aty128fb.c: In function `aty128_init':
aty128fb.c:1752: incompatible type for argument 1 of `fb_alloc_cmap'
make[2]: *** [aty128fb.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.5.25/drivers/video'
make[1]: *** [video] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.25/drivers'
make: *** [drivers] Error 2

I can live with 1406. it'll get cleaned up towards code freeze time.
1752 is:

fb_alloc_cmap(info->fb_info.cmap, size, 0);

Commenting this out resolves the compilation issue, but I don't think
is the right solution.

CONFIG_FB_ATY=y
CONFIG_FB_ATY_CT=y
CONFIG_FB_RADEON=y
CONFIG_FB_ATY128=y
CONFIG_FBCON_ADVANCED=y
CONFIG_FBCON_CFB8=y
CONFIG_FBCON_CFB16=y
CONFIG_FBCON_CFB24=y
CONFIG_FBCON_CFB32=y
CONFIG_FONT_8x8=y
CONFIG_FONT_8x16=y

BL.
--
Brad Littlejohn | Email: [email protected]
Unix Systems Administrator, | [email protected]
Web + NewsMaster, BOFH.. Smeghead! :) | http://www.wizard.com/~tyketto
PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569 F620 C819 199A E319 F0BF


2002-07-25 06:35:19

by James Simmons

[permalink] [raw]
Subject: Re: 2.5.28: aty128fb.c:1752: incompatible type

> -DKBUILD_BASENAME=aty128fb -c -o aty128fb.o aty128fb.c
> aty128fb.c: In function `aty128fb_set_var':
> aty128fb.c:1406: warning: implicit declaration of function `do_install_cmap'
> aty128fb.c: In function `aty128_init':
> aty128fb.c:1752: incompatible type for argument 1 of `fb_alloc_cmap'
> make[2]: *** [aty128fb.o] Error 1
> make[2]: Leaving directory `/usr/src/linux-2.5.25/drivers/video'
> make[1]: *** [video] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.5.25/drivers'
> make: *** [drivers] Error 2
>
> I can live with 1406. it'll get cleaned up towards code freeze time.
> 1752 is:
>
> fb_alloc_cmap(info->fb_info.cmap, size, 0);

Fix. Missed that change when I back rolled some code changes.

P.S

NOTE: The drivers using the old fbgen code are now broken. The next set
of fbdev changes will break most drivers. So if you see drivers broken it
is on purpose and please talk to the fbdev driver maintainer about
updating the driver.