2002-09-01 13:50:15

by Zwane Mwaikambo

Subject: [PATCH][2.5] set pci dma mask for ohci-hcd

Index: linux-2.5.33/drivers/usb/host/ohci-pci.c
===================================================================
RCS file: /build/cvsroot/linux-2.5.33/drivers/usb/host/ohci-pci.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 ohci-pci.c
--- linux-2.5.33/drivers/usb/host/ohci-pci.c 31 Aug 2002 22:30:41 -0000 1.1.1.1
+++ linux-2.5.33/drivers/usb/host/ohci-pci.c 1 Sep 2002 12:41:23 -0000
@@ -36,6 +36,11 @@
int ret;

if (hcd->pdev) {
+ if (pci_set_dma_mask(hcd->pdev, 0xFFFFFFFF)) {
+ err("couldn't set PCI dma mask");
+ return -EIO;
+ }
+
ohci->hcca = pci_alloc_consistent (hcd->pdev,
sizeof *ohci->hcca, &ohci->hcca_dma);
if (!ohci->hcca)

--
function.linuxpower.ca

2002-09-01 23:17:07

by David Brownell

Subject: Re: [PATCH][2.5] set pci dma mask for ohci-hcd

Last I looked, that value was documented to be the
default. Setting the default is not necessary, and
if it were done it should be done once (hcd.c) not
get repeated for every driver.

- Dave

2002-09-02 00:16:49

by David Miller

Subject: Re: [PATCH][2.5] set pci dma mask for ohci-hcd

From: David Brownell <[email protected]>
Date: Sun, 01 Sep 2002 16:21:12 -0700

Last I looked, that value was documented to be the
default.

That is correct.