2002-10-17 08:35:41

by Mikael Pettersson

[permalink] [raw]
Subject: [BUG] 2.5.42+ reboot kills Dell Latitude keyboard

Dell Latitude CPi laptop. Boot 2.5.42 or .43, then reboot.
Shortly after the screen is blanked and the BIOS starts, it
prints a "keyboard error" message and requests an F1 or F2
response (continue or go into SETUP). Never happened with any
other kernel on that machine.

Apparently the 2.5.42+ "let's shut everything down at reboot"
change put the keyboard controller in a state which is inconsistent
with the BIOS' expections at a warm boot.

First the disks-spun-down-at-reboot bug and now this. Sigh.


2002-10-17 09:28:46

by Eric W. Biederman

[permalink] [raw]
Subject: Re: [BUG] 2.5.42+ reboot kills Dell Latitude keyboard

Mikael Pettersson <[email protected]> writes:

> Dell Latitude CPi laptop. Boot 2.5.42 or .43, then reboot.
> Shortly after the screen is blanked and the BIOS starts, it
> prints a "keyboard error" message and requests an F1 or F2
> response (continue or go into SETUP). Never happened with any
> other kernel on that machine.
>
> Apparently the 2.5.42+ "let's shut everything down at reboot"
> change

There was no such change just a discussion of what the kernel
has been doing since 2.5.8 or so.

> put the keyboard controller in a state which is inconsistent
> with the BIOS' expections at a warm boot.

There is a bug in device_suspend. device_shutdown, and device_suspend
where merged and the POWER_DOWN case now removes the drivers which
is a bug. You may be getting hit with that.

Eric Blade has posed a patch fixing that.

Or else there is a change in the ->remove() method of one your drivers.

>
> First the disks-spun-down-at-reboot bug and now this. Sigh.

Someone implemented that in the IDE driver deliberately. I haven't
a clue why but it happened.

Eric

2002-10-17 11:12:13

by Mikael Pettersson

[permalink] [raw]
Subject: Re: [BUG] 2.5.42+ reboot kills Dell Latitude keyboard

Eric W. Biederman writes:
> Mikael Pettersson <[email protected]> writes:
>
> > Dell Latitude CPi laptop. Boot 2.5.42 or .43, then reboot.
> > Shortly after the screen is blanked and the BIOS starts, it
> > prints a "keyboard error" message and requests an F1 or F2
> > response (continue or go into SETUP). Never happened with any
> > other kernel on that machine.
> >
> > Apparently the 2.5.42+ "let's shut everything down at reboot"
> > change
>
> There was no such change just a discussion of what the kernel
> has been doing since 2.5.8 or so.
>
> > put the keyboard controller in a state which is inconsistent
> > with the BIOS' expections at a warm boot.
>
> There is a bug in device_suspend. device_shutdown, and device_suspend
> where merged and the POWER_DOWN case now removes the drivers which
> is a bug. You may be getting hit with that.
>
> Eric Blade has posed a patch fixing that.

I tried Eric Blade's patch
<http://marc.theaimsgroup.com/?l=linux-kernel&m=103477012517984&w=2>
but it didn't make any difference. Same keyboard error as before.

So either the patch doesn't change what actions are taken on reboot,
or the keyboard (std SERIO_I8042 + ATKBD PC stuff) driver was also
broken in the 2.5.41->2.5.42 step.

/Mikael

2002-10-17 14:11:56

by Eric W. Biederman

[permalink] [raw]
Subject: Re: [BUG] 2.5.42+ reboot kills Dell Latitude keyboard

Mikael Pettersson <[email protected]> writes:

> Eric W. Biederman writes:
> > Mikael Pettersson <[email protected]> writes:
> >
> > > Dell Latitude CPi laptop. Boot 2.5.42 or .43, then reboot.
> > > Shortly after the screen is blanked and the BIOS starts, it
> > > prints a "keyboard error" message and requests an F1 or F2
> > > response (continue or go into SETUP). Never happened with any
> > > other kernel on that machine.
> > >
> > > Apparently the 2.5.42+ "let's shut everything down at reboot"
> > > change
> >
> > There was no such change just a discussion of what the kernel
> > has been doing since 2.5.8 or so.
> >
> > > put the keyboard controller in a state which is inconsistent
> > > with the BIOS' expections at a warm boot.
> >
> > There is a bug in device_suspend. device_shutdown, and device_suspend
> > where merged and the POWER_DOWN case now removes the drivers which
> > is a bug. You may be getting hit with that.
> >
> > Eric Blade has posed a patch fixing that.
>
> I tried Eric Blade's patch
> <http://marc.theaimsgroup.com/?l=linux-kernel&m=103477012517984&w=2>
> but it didn't make any difference. Same keyboard error as before.
>
> So either the patch doesn't change what actions are taken on reboot,

Correctly only what actions are taken before reboot, are changed.

> or the keyboard (std SERIO_I8042 + ATKBD PC stuff) driver was also
> broken in the 2.5.41->2.5.42 step.

There is something in the ChangeLog about fixing the keyboard reboot
case. I don't see where the code changes in the patch but the
keyboard code was touched quite a bit.

So I suspect the keyboard driver also does the wrong thing for
you in this case.

Eric

2002-10-17 14:36:18

by dijital1

[permalink] [raw]
Subject: Re: [BUG] 2.5.42+ reboot kills Dell Latitude keyboard

Is there a controller difference between the Inspiron 4100 and your
latitude?

Ron Henry

"the illiterate of the future are not those who can neither read
or write; but those who cannot learn, unlearn, and relearn..."

On 17 Oct 2002, Eric W. Biederman wrote:

> Mikael Pettersson <[email protected]> writes:
>
> > Eric W. Biederman writes:
> > > Mikael Pettersson <[email protected]> writes:
> > >
> > > > Dell Latitude CPi laptop. Boot 2.5.42 or .43, then reboot.
> > > > Shortly after the screen is blanked and the BIOS starts, it
> > > > prints a "keyboard error" message and requests an F1 or F2
> > > > response (continue or go into SETUP). Never happened with any
> > > > other kernel on that machine.
> > > >
> > > > Apparently the 2.5.42+ "let's shut everything down at reboot"
> > > > change
> > >
> > > There was no such change just a discussion of what the kernel
> > > has been doing since 2.5.8 or so.
> > >
> > > > put the keyboard controller in a state which is inconsistent
> > > > with the BIOS' expections at a warm boot.
> > >
> > > There is a bug in device_suspend. device_shutdown, and device_suspend
> > > where merged and the POWER_DOWN case now removes the drivers which
> > > is a bug. You may be getting hit with that.
> > >
> > > Eric Blade has posed a patch fixing that.
> >
> > I tried Eric Blade's patch
> > <http://marc.theaimsgroup.com/?l=linux-kernel&m=103477012517984&w=2>
> > but it didn't make any difference. Same keyboard error as before.
> >
> > So either the patch doesn't change what actions are taken on reboot,
>
> Correctly only what actions are taken before reboot, are changed.
>
> > or the keyboard (std SERIO_I8042 + ATKBD PC stuff) driver was also
> > broken in the 2.5.41->2.5.42 step.
>
> There is something in the ChangeLog about fixing the keyboard reboot
> case. I don't see where the code changes in the patch but the
> keyboard code was touched quite a bit.
>
> So I suspect the keyboard driver also does the wrong thing for
> you in this case.
>
> Eric
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>