2002-11-05 04:51:48

by Zwane Mwaikambo

Subject: [PATCH][2.5-AC] Start from bank 0 for P4 MCE init (resend)

Index: linux-2.5.44-ac5/arch/i386/kernel/cpu/mcheck/p4.c
===================================================================
RCS file: /build/cvsroot/linux-2.5.44-ac5/arch/i386/kernel/cpu/mcheck/p4.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 p4.c
--- linux-2.5.44-ac5/arch/i386/kernel/cpu/mcheck/p4.c 3 Nov 2002 07:20:04 -0000 1.1.1.1
+++ linux-2.5.44-ac5/arch/i386/kernel/cpu/mcheck/p4.c 3 Nov 2002 16:47:14 -0000
@@ -220,7 +220,7 @@
wrmsr(MSR_IA32_MCG_CTL, 0xffffffff, 0xffffffff);
banks = l&0xff;

- for(i=1; i<banks; i++)
+ for(i=0; i<banks; i++)
wrmsr(MSR_IA32_MC0_CTL+4*i, 0xffffffff, 0xffffffff);

for(i=0; i<banks; i++)

--
function.linuxpower.ca

2002-11-05 13:29:58

by Dave Jones

Subject: Re: [PATCH][2.5-AC] Start from bank 0 for P4 MCE init (resend)

On Mon, Nov 04, 2002 at 11:59:38PM -0500, Zwane Mwaikambo wrote:
> Index: linux-2.5.44-ac5/arch/i386/kernel/cpu/mcheck/p4.c
> ===================================================================
> RCS file: /build/cvsroot/linux-2.5.44-ac5/arch/i386/kernel/cpu/mcheck/p4.c,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 p4.c
> --- linux-2.5.44-ac5/arch/i386/kernel/cpu/mcheck/p4.c 3 Nov 2002 07:20:04 -0000 1.1.1.1
> +++ linux-2.5.44-ac5/arch/i386/kernel/cpu/mcheck/p4.c 3 Nov 2002 16:47:14 -0000
> @@ -220,7 +220,7 @@
> wrmsr(MSR_IA32_MCG_CTL, 0xffffffff, 0xffffffff);
> banks = l&0xff;
>
> - for(i=1; i<banks; i++)
> + for(i=0; i<banks; i++)
> wrmsr(MSR_IA32_MC0_CTL+4*i, 0xffffffff, 0xffffffff);

Ack. Already in my mcheck bits due to go to Linus today.

Dave

--
| Dave Jones. http://www.codemonkey.org.uk