2002-11-27 23:47:13

by Frank Davis

Subject: 2.5.50 : fs/hugetlbfs/inode.c error

Hello all,
While 'make bzImage', I received the following error:

Regards,
Frank

fs/hugetlbfs/inode.c: In function `hugetlbfs_delete_inode':
fs/hugetlbfs/inode.c:212: `security_ops' undeclared (first use in this function)
fs/hugetlbfs/inode.c:212: (Each undeclared identifier is reported only once
fs/hugetlbfs/inode.c:212: for each function it appears in.)
fs/hugetlbfs/inode.c: In function `hugetlbfs_setattr':
fs/hugetlbfs/inode.c:336: `security_ops' undeclared (first use in this function)
make[2]: *** [fs/hugetlbfs/inode.o] Error 1
make[1]: *** [fs/hugetlbfs] Error 2
make: *** [fs] Error 2

2002-11-28 00:04:34

by Chris Wright

Subject: Re: 2.5.50 : fs/hugetlbfs/inode.c error

* Frank Davis ([email protected]) wrote:
>
> fs/hugetlbfs/inode.c: In function `hugetlbfs_delete_inode':
> fs/hugetlbfs/inode.c:212: `security_ops' undeclared (first use in this function)
> fs/hugetlbfs/inode.c:212: (Each undeclared identifier is reported only once
> fs/hugetlbfs/inode.c:212: for each function it appears in.)
> fs/hugetlbfs/inode.c: In function `hugetlbfs_setattr':
> fs/hugetlbfs/inode.c:336: `security_ops' undeclared (first use in this function)

Yup, GregKH missed this one and posted a patch to Linus just as 2.5.50 was
released. The following patch from GregKH will fix this error. This is
already in 2.5-bk.

-chris

===== fs/hugetlbfs/inode.c 1.4 vs 1.5 =====
--- 1.4/fs/hugetlbfs/inode.c Wed Nov 20 03:19:02 2002
+++ 1.5/fs/hugetlbfs/inode.c Wed Nov 27 15:09:41 2002
@@ -209,7 +209,7 @@
if (inode->i_data.nrpages)
truncate_hugepages(&inode->i_data, 0);

- security_ops->inode_delete(inode);
+ security_inode_delete(inode);

clear_inode(inode);
destroy_inode(inode);
@@ -333,7 +333,7 @@
if (error)
goto out;

- error = security_ops->inode_setattr(dentry, attr);
+ error = security_inode_setattr(dentry, attr);
if (error)
goto out;