2002-12-07 09:31:13

by Nathaniel Russell

[permalink] [raw]
Subject: [PATCH 2.4.20] Via 8233 Sound Support

This patch adds support for the Via8233 Onboard Sound Card.
This patch applies to Linux Kernel 2.4.20 cleanly.
The only file this patch touch's is drivers/sound/via82cxxx_audio.c

Please apply to current Linux Kernel 2.4.x

Nathaniel

Please CC me as I'm not subscribed to the list
[email protected]


Attachments:
sound.diff (762.00 B)
Via 8233 Sound Support

2002-12-07 09:47:08

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH 2.4.20] Via 8233 Sound Support

Nathaniel Russell wrote:
> diff -urN linux-sound/drivers/sound/via82cxxx_audio.c linux/drivers/sound/via82cxxx_audio.c
> --- linux-sound/drivers/sound/via82cxxx_audio.c 2002-08-02 20:39:44.000000000 -0400
> +++ linux/drivers/sound/via82cxxx_audio.c 2002-12-07 04:28:04.000000000 -0500
> @@ -354,6 +353,8 @@
> static struct pci_device_id via_pci_tbl[] __initdata = {
> { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5,
> PCI_ANY_ID, PCI_ANY_ID, },
> + { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8233_5,
> + PCI_ANY_ID, PCI_ANY_ID, },
> { 0, }
> };
> MODULE_DEVICE_TABLE(pci,via_pci_tbl);


unfortunately this only works sporadically, and only for some motherboards.

There is a reason why I removed this pci id from the driver, after
foolishly adding it :)

2002-12-07 09:55:45

by Nathaniel Russell

[permalink] [raw]
Subject: Re: [PATCH 2.4.20] Via 8233 Sound Support

Ok i agree with you it turns out my mp3's i always listen to with my
Esoniq card dont wanna play with my Via card.
Well it's ok. So Jeff is my patch for the Via AGP card ok to add to the
Kernel ;) just a wounder.
Nathaniel
CC [email protected]

On Sat, 7 Dec 2002, Jeff Garzik wrote:

> Nathaniel Russell wrote:
> > diff -urN linux-sound/drivers/sound/via82cxxx_audio.c linux/drivers/sound/via82cxxx_audio.c
> > --- linux-sound/drivers/sound/via82cxxx_audio.c 2002-08-02 20:39:44.000000000 -0400
> > +++ linux/drivers/sound/via82cxxx_audio.c 2002-12-07 04:28:04.000000000 -0500
> > @@ -354,6 +353,8 @@
> > static struct pci_device_id via_pci_tbl[] __initdata = {
> > { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5,
> > PCI_ANY_ID, PCI_ANY_ID, },
> > + { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8233_5,
> > + PCI_ANY_ID, PCI_ANY_ID, },
> > { 0, }
> > };
> > MODULE_DEVICE_TABLE(pci,via_pci_tbl);
>
>
> unfortunately this only works sporadically, and only for some motherboards.
>
> There is a reason why I removed this pci id from the driver, after
> foolishly adding it :)
>

2002-12-07 10:15:57

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH 2.4.20] Via 8233 Sound Support

Nathaniel Russell wrote:
> Ok i agree with you it turns out my mp3's i always listen to with my
> Esoniq card dont wanna play with my Via card.
> Well it's ok. So Jeff is my patch for the Via AGP card ok to add to the
> Kernel ;) just a wounder.

I have no idea :) Find a 3D card, and test it, making sure that AGP and
DRM are both turned on.

Also, Dave Jones did a really nice cleanup of agpgart in 2.5, so even
though there is no agpgart MAINTAINERS entry, I think he would be a good
target for patches :) Even thought 2.5 agpgart is clearly different,
davej has a clue about it and could probably ack or apply 2.4 patches...

Jeff