2003-01-11 12:34:57

by Rui Sousa

[permalink] [raw]
Subject: [PATCH] emu10k1 forward port (2.4.20 to 2.5.56)


Hi,

Since the driver is still in the tree and several people already asked for
it, here is an update to the OSS emu10k1 driver in 2.5.56. This is the
exactly same driver as in 2.4.20, it fixes a compile warning and a number
of bugs:

0.17 Fix for mixer SOUND_MIXER_INFO ioctl.
Fix for HIGHMEM machines (emu10k1 can only do 31 bit bus
master)
midi poll initial implementation.
Small mixer fixes/cleanups.
Improved support for 5.1 cards.
0.18 Fix for possible leak in pci_alloc_consistent()
Cleaned up poll() functions (audio and midi). Don't start
input.
Restrict DMA pages used to 512Mib range.
New AC97_BOOST mixer ioctl.
0.19 Real fix for kernel with highmem support (cast dma_handle to
u32).
Fix recording buffering parameters calculation.
Use unsigned long for variables in bit ops.
0.20 Fixed recording startup
Fixed timer rate setting (it's a 16-bit register)


Please apply,

Rui


Attachments:
emu10k1-2.5.56.patch.bz2 (12.56 kB)
emu10k1 patch

2003-01-15 07:59:06

by Mikael Pettersson

[permalink] [raw]
Subject: Re: [PATCH] emu10k1 forward port (2.4.20 to 2.5.56)

Rui Sousa writes:
> Since the driver is still in the tree and several people already asked for
> it, here is an update to the OSS emu10k1 driver in 2.5.56. This is the
> exactly same driver as in 2.4.20, it fixes a compile warning and a number
> of bugs:

Tested in kernel 2.5.58 with an SB Live 5.1. Works great with Quake :-)
And it killed those bitops compile warnings, so I'm happy with it.

/Mikael

2003-01-15 13:31:33

by Alistair John Strachan

[permalink] [raw]
Subject: Re: [PATCH] emu10k1 forward port (2.4.20 to 2.5.56)

Hi,

This diff applies over the top of Rui's diff to provide the
__copy_{to,from}_user fixes present in -dj. The merging of both these diffs
would remove all the remaining important emu10k1 changes from -dj.

Cheers,
Alistair Strachan.


Attachments:
(No filename) (238.00 B)
emu10k1-dj-fixes.diff (3.96 kB)
Download all attachments

2003-01-15 14:22:58

by Rui Sousa

[permalink] [raw]
Subject: Re: [PATCH] emu10k1 forward port (2.4.20 to 2.5.56)

On Wed, 15 Jan 2003, Alistair Strachan wrote:

I'm still not sure if I agree with this change... Couldn't be possible
that even if one __copy_from_user() fails the next one could succeed?
Is it really necessary to return at the first error?

Rui

> Hi,
>
> This diff applies over the top of Rui's diff to provide the
> __copy_{to,from}_user fixes present in -dj. The merging of both these diffs
> would remove all the remaining important emu10k1 changes from -dj.
>
> Cheers,
> Alistair Strachan.
>