2003-02-07 17:00:48

by Frank Davis

Subject: [PATCH] 2.5.59 : drivers/char/ite_gpio.c

Hello all,
The following patch addresses buzilla bug # 321, and removes a double
logical issue. Please review for inclusion.

Regards,
Frank


--- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
+++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
@@ -140,7 +140,7 @@
{
int ret=-1;

- if (MAX_GPIO_LINE > *data >= 0)
+ if ((MAX_GPIO_LINE > *data) && (*data >= 0))
ret=ite_gpio_irq_pending[*data];

DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));

2003-02-10 01:38:07

by Rusty Russell

Subject: Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c

In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write:
> --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
> +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
> @@ -140,7 +140,7 @@
> {
> int ret=-1;
>
> - if (MAX_GPIO_LINE > *data >= 0)
> + if ((MAX_GPIO_LINE > *data) && (*data >= 0))
> ret=ite_gpio_irq_pending[*data];
>
> DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));

Nope, of course *data is >= 0, it's a u32.

Once again, the author needs to indicate (and test!) what was meant
here...

Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

2003-02-10 10:03:46

by Horst von Brand

Subject: Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c

Rusty Russell <[email protected]> said:
> In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write:
> > --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
> > +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
> > @@ -140,7 +140,7 @@
> > {
> > int ret=-1;
> >
> > - if (MAX_GPIO_LINE > *data >= 0)
> > + if ((MAX_GPIO_LINE > *data) && (*data >= 0))
> > ret=ite_gpio_irq_pending[*data];
> >
> > DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));
>
> Nope, of course *data is >= 0, it's a u32.

MAX_GPIO_LINE > *data >= 0 is (MAX_GPIO_LINE > *data) >= 0 is (0 or 1) >= 0
is 1 ;-)
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513