2003-02-07 17:05:56

by Frank Davis

Subject: [PATCH] 2.5.59 : drivers/scsi/advansys.c

Hello all,
The following patch addresses buzilla bug # 324, and removes a double
logical issue. Please review for inclusion.

Regards,
Frank

--- linux/drivers/scsi/advansys.c.old 2003-01-16 21:21:49.000000000 -0500
+++ linux/drivers/scsi/advansys.c 2003-02-07 02:09:58.000000000 -0500
@@ -7100,7 +7100,7 @@
* then return the number of underrun bytes.
*/
if (scp->request_bufflen != 0 && qdonep->remain_bytes != 0 &&
- qdonep->remain_bytes <= scp->request_bufflen != 0) {
+ qdonep->remain_bytes <= scp->request_bufflen && scp->request_bufflen!= 0) {
ASC_DBG1(1, "asc_isr_callback: underrun condition %u bytes\n",
(unsigned) qdonep->remain_bytes);
scp->resid = qdonep->remain_bytes;

2003-02-07 17:29:24

by Dave Jones

Subject: Re: [PATCH] 2.5.59 : drivers/scsi/advansys.c

On Fri, Feb 07, 2003 at 12:24:54PM -0500, Frank Davis wrote:

> if (scp->request_bufflen != 0 && qdonep->remain_bytes != 0 &&
> - qdonep->remain_bytes <= scp->request_bufflen != 0) {
> + qdonep->remain_bytes <= scp->request_bufflen && scp->request_bufflen!= 0) {

you now have two scp->request_bufflen != 0 checks.

Dave

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs

2003-02-10 01:38:20

by Rusty Russell

Subject: Re: [PATCH] 2.5.59 : drivers/scsi/advansys.c

In message <Pine.LNX.4.44.0302071223250.6917-100000@master> you write:
> Hello all,
> The following patch addresses buzilla bug # 324, and removes a double
> logical issue. Please review for inclusion.
>
> Regards,
> Frank

Once again, the author needs to say what they want here.

Andy?

Thanks,
Rusty.


> --- linux/drivers/scsi/advansys.c.old 2003-01-16 21:21:49.000000000 -0500
> +++ linux/drivers/scsi/advansys.c 2003-02-07 02:09:58.000000000 -0500
> @@ -7100,7 +7100,7 @@
> * then return the number of underrun bytes.
> */
> if (scp->request_bufflen != 0 && qdonep->remain_bytes != 0 &&
> - qdonep->remain_bytes <= scp->request_bufflen != 0) {
> + qdonep->remain_bytes <= scp->request_bufflen && scp->request_bufflen!= 0) {
> ASC_DBG1(1, "asc_isr_callback: underrun condition %u bytes\n",
> (unsigned) qdonep->remain_bytes);
> scp->resid = qdonep->remain_bytes;
>

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.