2003-02-18 15:54:30

by Robert P. J. Day

Subject: why is "scripts/elfconfig.h" not removed with "make mrproper"?

i just verified that the original 2.5.62 kernel tree does not
start with the header file "scripts/elfconfig.h". this file is
created by running "make xconfig", even when nothing is configured.
but that file is *not* removed by running "make mrproper", which
i would think it should be.

won't this cause a problem when generating patches, since
that elfconfig.h file will show up every time?

rday

2003-02-18 17:07:05

by Sam Ravnborg

Subject: Re: why is "scripts/elfconfig.h" not removed with "make mrproper"?

On Tue, Feb 18, 2003 at 11:01:29AM -0500, Robert P. J. Day wrote:
>
> i just verified that the original 2.5.62 kernel tree does not
> start with the header file "scripts/elfconfig.h". this file is
> created by running "make xconfig", even when nothing is configured.
> but that file is *not* removed by running "make mrproper", which
> i would think it should be.
>
> won't this cause a problem when generating patches, since
> that elfconfig.h file will show up every time?

The following patch fixes this:

===== scripts/Makefile 1.30 vs edited =====
--- 1.30/scripts/Makefile Mon Feb 17 04:20:26 2003
+++ edited/scripts/Makefile Tue Feb 18 18:12:22 2003
@@ -11,6 +11,7 @@
host-progs := fixdep split-include conmakehash docproc kallsyms modpost \
mk_elfconfig
build-targets := $(host-progs) empty.o
+EXTRA_TARGETS := elfconfig.h

modpost-objs := modpost.o file2alias.o

@@ -30,4 +31,3 @@
$(obj)/elfconfig.h: $(obj)/empty.o $(obj)/mk_elfconfig FORCE
$(call if_changed,elfconfig)

-targets += $(obj)/elfconfig.h

2003-02-18 17:38:33

by Kai Germaschewski

Subject: Re: why is "scripts/elfconfig.h" not removed with "make mrproper"?

On Tue, 18 Feb 2003, Robert P. J. Day wrote:

> i just verified that the original 2.5.62 kernel tree does not
> start with the header file "scripts/elfconfig.h". this file is
> created by running "make xconfig", even when nothing is configured.
> but that file is *not* removed by running "make mrproper", which
> i would think it should be.

Right.

--Kai


===== scripts/Makefile 1.30 vs edited =====
--- 1.30/scripts/Makefile Sun Feb 16 21:20:26 2003
+++ edited/scripts/Makefile Tue Feb 18 11:47:10 2003
@@ -17,6 +17,8 @@
# Let clean descend into subdirs
subdir- := lxdialog kconfig

+clean-files := elfconfig.h
+
# fixdep is needed to compile other host programs
$(addprefix $(obj)/,$(filter-out fixdep,$(build-targets))): $(obj)/fixdep