The problem is that the parisc libgcc.a library contains symbols that
look like $$mulI and the like, but genksyms doesn't think $ is legal for
a function symbol, so they all get dropped from the output. This means
that inserting almost any module on parisc taints the kernel because
these symbols have no version.
The fix (attached below) was to allow $ in an identifier in lex.l (and
obviously to update the _shipped files as well, but my flex/bison seem
to be rather different from the one they were generated with, so I'll
leave that to whomever has the correct versions).
James
In message <1056410864.1826.57.camel@mulgrave> you write:
> The problem is that the parisc libgcc.a library contains symbols that
> look like $$mulI and the like, but genksyms doesn't think $ is legal for
> a function symbol, so they all get dropped from the output. This means
> that inserting almost any module on parisc taints the kernel because
> these symbols have no version.
>
> The fix (attached below) was to allow $ in an identifier in lex.l (and
> obviously to update the _shipped files as well, but my flex/bison seem
> to be rather different from the one they were generated with, so I'll
> leave that to whomever has the correct versions).
Looks fine, but my flex is different, too. Kai?
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
===== scripts/genksyms/lex.l 1.2 vs edited =====
--- 1.2/scripts/genksyms/lex.l Wed Feb 19 16:42:13 2003
+++ edited/scripts/genksyms/lex.l Mon Jun 23 17:17:17 2003
@@ -37,7 +37,7 @@
%}
-IDENT [A-Za-z_][A-Za-z0-9_]*
+IDENT [A-Za-z_\$][A-Za-z0-9_\$]*
O_INT 0[0-7]*
D_INT [1-9][0-9]*
On Wed, 25 Jun 2003, Rusty Russell wrote:
> In message <1056410864.1826.57.camel@mulgrave> you write:
> > The problem is that the parisc libgcc.a library contains symbols that
> > look like $$mulI and the like, but genksyms doesn't think $ is legal for
> > a function symbol, so they all get dropped from the output. This means
> > that inserting almost any module on parisc taints the kernel because
> > these symbols have no version.
> >
> > The fix (attached below) was to allow $ in an identifier in lex.l (and
> > obviously to update the _shipped files as well, but my flex/bison seem
> > to be rather different from the one they were generated with, so I'll
> > leave that to whomever has the correct versions).
>
> Looks fine, but my flex is different, too. Kai?
I merged it, will submit.
--Kai
On Wed, Jun 25, 2003 at 10:22:09PM +0200, Kai Germaschewski wrote:
> On Wed, 25 Jun 2003, Rusty Russell wrote:
>
> > In message <1056410864.1826.57.camel@mulgrave> you write:
> > > The problem is that the parisc libgcc.a library contains symbols that
> > > look like $$mulI and the like, but genksyms doesn't think $ is legal for
> > > a function symbol, so they all get dropped from the output. This means
> > > that inserting almost any module on parisc taints the kernel because
> > > these symbols have no version.
> > >
> > > The fix (attached below) was to allow $ in an identifier in lex.l (and
> > > obviously to update the _shipped files as well, but my flex/bison seem
> > > to be rather different from the one they were generated with, so I'll
> > > leave that to whomever has the correct versions).
> >
> > Looks fine, but my flex is different, too. Kai?
>
> I merged it, will submit.
Could you divulge what version of flex you use, to simplify future
changes?
Regards: David Weinehall
--
/) David Weinehall <[email protected]> /) Northern lights wander (\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\) http://www.acc.umu.se/~tao/ (/ Full colour fire (/
On Mon, 30 Jun 2003, David Weinehall wrote:
> Could you divulge what version of flex you use, to simplify future
> changes?
Well, the standard RedHat 7.3 stuff - unfortunately that box is moving
currently, so I don't know the versions. But any version should work, the
diff may be bigger, but the interesting change is to lex.l, anyway.
--Kai